New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation around the new CLA status check #390

Merged
merged 3 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@johlju
Contributor

johlju commented May 30, 2018

Since the CLA bot behavior has change the documentation should reflect that.

Fixes #323


This change is Reviewable

@johlju johlju requested a review from kwirkykat May 30, 2018

@johlju johlju added the needs review label May 30, 2018

Show outdated Hide outdated CONTRIBUTING.md
@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Jul 3, 2018

Contributor

:LGTM:

Merging this, if there is any problem with the image, I make sure to fix it.


Reviewed 3 of 5 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed, 1 unresolved discussion (waiting on @kwirkykat)


CONTRIBUTING.md, line 266 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

I fixed the alt text - but it rendered okay for me in both Safari and Chrome before that. Can you screen shot how it looks like for you? Maybe it's the picture that is wrong.

Done.


Comments from Reviewable

Contributor

johlju commented Jul 3, 2018

:LGTM:

Merging this, if there is any problem with the image, I make sure to fix it.


Reviewed 3 of 5 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed, 1 unresolved discussion (waiting on @kwirkykat)


CONTRIBUTING.md, line 266 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

I fixed the alt text - but it rendered okay for me in both Safari and Chrome before that. Can you screen shot how it looks like for you? Maybe it's the picture that is wrong.

Done.


Comments from Reviewable

@johlju johlju merged commit 9d77268 into PowerShell:master Jul 3, 2018

1 of 2 checks passed

code-review/reviewable 1 discussion left (kwirkykat)
Details
license/cla All CLA requirements met.
Details

@johlju johlju removed the needs review label Jul 3, 2018

@johlju johlju deleted the johlju:fix-cla-signing branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment