New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #397

Merged
merged 3 commits into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@johlju
Contributor

johlju commented May 30, 2018

  • Remove reference to 'supported' which could be misleading.
  • Minor updates to text.

Some white spaces was removed since VSCode is configured to do that.


This change is Reviewable

Update README.md
- Remove reference to 'supported' which could be misleading.
- Minor updates to text.

@johlju johlju requested a review from kwirkykat May 30, 2018

@johlju johlju added the needs review label May 30, 2018

@PlagueHO

This comment has been minimized.

Show comment
Hide comment
@PlagueHO

PlagueHO May 31, 2018

Contributor

Review status: all files reviewed at latest revision, all discussions resolved.


README.md, line 7 at r1 (raw file):

This is the central repository for the DSC Resource Kit, a collection of DSC resources maintained and released by Microsoft.

A dashboard of all open issues and pull requests across DSC Resource Kit is available at the [DSC Resource Kit Waffle board](http://waffle.io/powershell/dscresources).

at -> on


README.md, line 31 at r1 (raw file):

All DSC resource modules are also listed as submodules of this repository (DscResources) in the [xDscResources folder](https://github.com/PowerShell/DscResources/tree/master/xDscResources) or [DscResources folder](https://github.com/PowerShell/DscResources/tree/master/DscResources).
Read about the difference in naming under

Maybe: "Read about the differences in naming under the High Quality Resource Module section."?


Comments from Reviewable

Contributor

PlagueHO commented May 31, 2018

Review status: all files reviewed at latest revision, all discussions resolved.


README.md, line 7 at r1 (raw file):

This is the central repository for the DSC Resource Kit, a collection of DSC resources maintained and released by Microsoft.

A dashboard of all open issues and pull requests across DSC Resource Kit is available at the [DSC Resource Kit Waffle board](http://waffle.io/powershell/dscresources).

at -> on


README.md, line 31 at r1 (raw file):

All DSC resource modules are also listed as submodules of this repository (DscResources) in the [xDscResources folder](https://github.com/PowerShell/DscResources/tree/master/xDscResources) or [DscResources folder](https://github.com/PowerShell/DscResources/tree/master/DscResources).
Read about the difference in naming under

Maybe: "Read about the differences in naming under the High Quality Resource Module section."?


Comments from Reviewable

johlju added some commits May 31, 2018

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju May 31, 2018

Contributor

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


README.md, line 7 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

at -> on

Done.


README.md, line 31 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Maybe: "Read about the differences in naming under the High Quality Resource Module section."?

Done.


Comments from Reviewable

Contributor

johlju commented May 31, 2018

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


README.md, line 7 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

at -> on

Done.


README.md, line 31 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Maybe: "Read about the differences in naming under the High Quality Resource Module section."?

Done.


Comments from Reviewable

@PlagueHO

This comment has been minimized.

Show comment
Hide comment
@PlagueHO

PlagueHO Jun 1, 2018

Contributor

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Contributor

PlagueHO commented Jun 1, 2018

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju removed the request for review from kwirkykat Jun 1, 2018

@johlju johlju merged commit ec718b2 into PowerShell:master Jun 1, 2018

2 checks passed

code-review/reviewable 1 file reviewed
Details
license/cla All CLA requirements met.
Details

@johlju johlju removed the needs review label Jun 1, 2018

@johlju johlju deleted the johlju:fix-readme branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment