New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text around new resource module submission #398

Merged
merged 2 commits into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@johlju
Contributor

johlju commented May 31, 2018

  • Update text around new resource module submission
  • Adds new issue templates
    • Issue template for 'New resource module submission'
    • Issue template for 'General questions'
    • Issue tempate for 'Problem with resource module'

Fixes #356


This change is Reviewable

Update text around new resource module submission
- Adds new issue templates
  - Issue template for 'New resource module submission'
  - Issue template for 'General questions'
  - Issue tempate for 'Problem with resource module'

@johlju johlju requested a review from mgreenegit May 31, 2018

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju May 31, 2018

Contributor

@mgreenegit could you please look at the text in these files for accuracy?

  • NewResourceModuleSubmissions.md
  • .github/ISSUE_TEMPLATE/New_resource_module_submission.md

@PlagueHO could you please proof read the text when you have a chance? 😃

Contributor

johlju commented May 31, 2018

@mgreenegit could you please look at the text in these files for accuracy?

  • NewResourceModuleSubmissions.md
  • .github/ISSUE_TEMPLATE/New_resource_module_submission.md

@PlagueHO could you please proof read the text when you have a chance? 😃

@johlju johlju added the needs review label May 31, 2018

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju May 31, 2018

Contributor

@kwirkykat Maybe you would like to look over these as well?

Contributor

johlju commented May 31, 2018

@kwirkykat Maybe you would like to look over these as well?

@PlagueHO

This comment has been minimized.

Show comment
Hide comment
@PlagueHO

PlagueHO Jun 1, 2018

Contributor

Review status: all files reviewed at latest revision, all discussions resolved.


NewResourceModuleSubmissions.md, line 1 at r1 (raw file):

# How to do a resource module submission

BTW, might read better:
do -> perform


NewResourceModuleSubmissions.md, line 18 at r1 (raw file):

When you think your resource module is ready for listing in DSC Resource Kit,
then the first step is to create a new issue with the *New resource module submission* issue

BTW: might read better:
with -> using


NewResourceModuleSubmissions.md, line 28 at r1 (raw file):

The maintainer (owner) of the resource module, and the community, will contribute
and give support to the resource module (in the owners repository) on a voluntary

BTW:
give support to the resource module -> support the resource module


Comments from Reviewable

Contributor

PlagueHO commented Jun 1, 2018

Review status: all files reviewed at latest revision, all discussions resolved.


NewResourceModuleSubmissions.md, line 1 at r1 (raw file):

# How to do a resource module submission

BTW, might read better:
do -> perform


NewResourceModuleSubmissions.md, line 18 at r1 (raw file):

When you think your resource module is ready for listing in DSC Resource Kit,
then the first step is to create a new issue with the *New resource module submission* issue

BTW: might read better:
with -> using


NewResourceModuleSubmissions.md, line 28 at r1 (raw file):

The maintainer (owner) of the resource module, and the community, will contribute
and give support to the resource module (in the owners repository) on a voluntary

BTW:
give support to the resource module -> support the resource module


Comments from Reviewable

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Jun 1, 2018

Contributor

@PlagueHO Thanks for the proof reading - I was expecting more review comments 😃


Review status: 3 of 4 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Contributor

johlju commented Jun 1, 2018

@PlagueHO Thanks for the proof reading - I was expecting more review comments 😃


Review status: 3 of 4 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Jun 1, 2018

Contributor

I won't merge this until it's approved by either @kwirkykat or @mgreenegit

Contributor

johlju commented Jun 1, 2018

I won't merge this until it's approved by either @kwirkykat or @mgreenegit

@johlju johlju requested a review from kwirkykat Jun 9, 2018

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Jul 3, 2018

Contributor

@kwirkykat @mgreenegit I will self-review this in a day or so, and then I will merge this. If you have any comment, please review until then. 🙂

Contributor

johlju commented Jul 3, 2018

@kwirkykat @mgreenegit I will self-review this in a day or so, and then I will merge this. If you have any comment, please review until then. 🙂

@PlagueHO

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mgreenegit and @kwirkykat)

@johlju johlju merged commit fcc127a into PowerShell:master Jul 6, 2018

2 checks passed

code-review/reviewable 4 files reviewed (kwirkykat, mgreenegit)
Details
license/cla All CLA requirements met.
Details

@johlju johlju removed the needs review label Jul 6, 2018

@johlju johlju deleted the johlju:how-to-make-module-submission branch Jul 6, 2018

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Jul 6, 2018

Contributor

@PlagueHO Thank you for the review!

Contributor

johlju commented Jul 6, 2018

@PlagueHO Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment