New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DscResource.Template #411

Merged
merged 5 commits into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@johlju
Contributor

johlju commented Jul 2, 2018

  • Update appveyor.yml to support publishing of examples

This change is Reviewable

Update DscResource.Template
- Update appveyor.yml to support publishing of examples
@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Jul 3, 2018

Contributor

@PlagueHO Another small one to review.

Contributor

johlju commented Jul 3, 2018

@PlagueHO Another small one to review.

@PlagueHO

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @PlagueHO and @johlju)


DscResource.Template/appveyor.yml, line 18 at r1 (raw file):

environment:
  gallery_api:
    # TODO: Chnage to correct APU key.

APU? or API?


DscResource.Template/appveyor.yml, line 19 at r1 (raw file):

  gallery_api:
    # TODO: Chnage to correct APU key.
    # This API key only works for resource modules under DSC Resource Kit.

Might be worth making it clear that this particular key can only be decrypted by the PowerShell team's AppVeyor account and that if you wished to use this to publish your own module you'd need to set your own key. Non-blocking.

@PlagueHO

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


DscResource.Template/appveyor.yml, line 18 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

APU? or API?

Oh wait, I seemed to have reviewed an old version or something....

@johlju

Fix the comments. 😃

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @PlagueHO)


DscResource.Template/appveyor.yml, line 18 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Oh wait, I seemed to have reviewed an old version or something....

Yes, saw my mistake this morning so quickly fixed it :)


DscResource.Template/appveyor.yml, line 19 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Might be worth making it clear that this particular key can only be decrypted by the PowerShell team's AppVeyor account and that if you wished to use this to publish your own module you'd need to set your own key. Non-blocking.

Done. Improved the text, used bits from your comment 😁

@PlagueHO

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 2265cb3 into PowerShell:master Jul 6, 2018

2 checks passed

code-review/reviewable 1 file reviewed
Details
license/cla All CLA requirements met.
Details

@johlju johlju removed the needs review label Jul 6, 2018

@johlju johlju deleted the johlju:update-dscresource-template branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment