New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated texts around abandoned PR's (issue #412) #413

Merged
merged 3 commits into from Jul 7, 2018

Conversation

Projects
None yet
1 participant
@johlju
Contributor

johlju commented Jul 3, 2018

  • Updated texts around abandoned PR's (issue #412)
  • Updated some text that references wrong labels.

This change is Reviewable

@johlju johlju added the needs review label Jul 3, 2018

@johlju

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion


GettingStartedWithGitHub.md, line 318 at r1 (raw file):

- If the original contributor is unable to continue the work on a pull request _and_ the original author signed the CLA.
- If the pull request have been labeled with the *abandoned* label.

Should also say something like "(which implies that the CLA was signed - otherwise the abandoned label should not have been set)"

johlju added some commits Jul 7, 2018

@johlju

Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @johlju)


GettingStartedWithGitHub.md, line 318 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should also say something like "(which implies that the CLA was signed - otherwise the abandoned label should not have been set)"

Done

@johlju

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 4834310 into PowerShell:master Jul 7, 2018

2 checks passed

code-review/reviewable 2 files reviewed
Details
license/cla All CLA requirements met.
Details

@johlju johlju removed the needs review label Jul 7, 2018

@johlju johlju deleted the johlju:update-abandoned-texts branch Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment