-
Notifications
You must be signed in to change notification settings - Fork 39
Adding integration with Travis CI / Linux #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR fixes #24 |
.travis.yml
Outdated
@@ -0,0 +1,22 @@ | |||
language: cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems better to change this to csharp
now as we're likely to convert this to C# in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
fast_finish: true | ||
|
||
install: | ||
- git clone https://github.com/PowerShell/PowerShell.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this point to the Microsoft.PowerShell.Archive
repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used as an easy way to get the script that downloads the latest PS on test machine (PowerShell/PowerShell : tools/download.sh).
With our frequent PS releases, it would be a maintenance pain to add a copy of that download script to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we just need to apt-get
or yum
our most recent official release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe; but looks like it requires sudo.
Also, currently Travis CI in PowerShell/PowerShell uses this download script, so I just want to reuse something that is known to be working reliably for some time. Feel free to open low-pri issue to replace PS deployment steps with apt-get.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for now then.
Microsoft.PowerShell.Archive repo now will run test passes in Travis CI / Linux.
Added Travis CI status badge for 'master' branch to the main ReadMe.md
Test passes in Travis CI / Linux will use the same version of PowerShell that is used by Travis CI for 'PowerShell/PowerShell' repo. (currently '6.0.0-alpha.17')