Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Convert Module Name to NetworkingDsc #290
As per recent DSC Resource Naming guidelines changes:
I wanted to complete #135 before converting to NetworkingDsc, but I think this will take at least a few weeks if I do one resource every couple of days (takes a little bit of time for reviews to go through). But there isn't strictly any reason why I need to complete the HQRM work before renaming this module.
I'd love to have this complete before next resource kit release (end of Jan?) - so would that timeline work for you?
referenced this issue
May 5, 2018
@PlagueHO I had the NetAdapterAdvancedProperty with a slightly different implementation. https://github.com/rchaganti/NetworkingDsc/blob/master/DSCResources/NetworkAdapterProperty/NetworkAdapterProperty.Schema.mof
I am not hard coding the property names in the schema as value map. Mine is more of a generic implementation. Please review my code and let me know if that is OK. I plan to remove the ID property from the schema though and implement multiple properties (netadaptername and propertyname as keys). If you think this is OK, I will modify NetAdapterAdvancedProperty in this module and submit a PR.