Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Module Name to NetworkingDsc #290

Closed
PlagueHO opened this issue Dec 8, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@PlagueHO
Copy link
Collaborator

commented Dec 8, 2017

As per recent DSC Resource Naming guidelines changes:
https://github.com/PowerShell/DscResources/blob/master/Naming.md

@rchaganti

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2017

I just started NetworkingDsc in my account. I have a new resource that I needed and thought why not start making it as a HQRM. You can check it at https://github.com/rchaganti/NetworkingDsc.

@PlagueHO

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 21, 2017

Hi @rchaganti - great stuff! Are you planning on merging your NetworkingDsc in with this repo once we've completed the rename?

@rchaganti

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2017

Yes. Do you have any timelines?

@PlagueHO

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 21, 2017

I wanted to complete #135 before converting to NetworkingDsc, but I think this will take at least a few weeks if I do one resource every couple of days (takes a little bit of time for reviews to go through). But there isn't strictly any reason why I need to complete the HQRM work before renaming this module.

I'd love to have this complete before next resource kit release (end of Jan?) - so would that timeline work for you?

@rchaganti

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2017

Yes, that will work. I will start adding tests to my resource. Is there any new resource backlog that you are tracking? I can help write some after holidays.

@PlagueHO PlagueHO added in progress and removed help wanted labels May 5, 2018

@PlagueHO PlagueHO closed this in #330 May 8, 2018

PlagueHO added a commit that referenced this issue May 8, 2018

Merge pull request #330 from PlagueHO/Issue-290
BREAKING CHANGE: Rename xNetworking to NetworkingDsc - Fixes #290

@joeyaiello joeyaiello removed the in progress label May 8, 2018

@PlagueHO

This comment has been minimized.

Copy link
Collaborator Author

commented May 8, 2018

Hi @rchaganti - sorry it took so long, but we've now completed the rename of xNetworking to NetworkingDsc. So if the offer of including your resources is still available then they'd be gratefully accepted!

@rchaganti

This comment has been minimized.

Copy link
Contributor

commented May 8, 2018

@PlagueHO I had the NetAdapterAdvancedProperty with a slightly different implementation. https://github.com/rchaganti/NetworkingDsc/blob/master/DSCResources/NetworkAdapterProperty/NetworkAdapterProperty.Schema.mof

I am not hard coding the property names in the schema as value map. Mine is more of a generic implementation. Please review my code and let me know if that is OK. I plan to remove the ID property from the schema though and implement multiple properties (netadaptername and propertyname as keys). If you think this is OK, I will modify NetAdapterAdvancedProperty in this module and submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.