Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors #472

Closed
lzybkr opened this issue Nov 9, 2016 · 5 comments
Closed

Colors #472

lzybkr opened this issue Nov 9, 2016 · 5 comments

Comments

@lzybkr
Copy link
Member

@lzybkr lzybkr commented Nov 9, 2016

From @vors on May 25, 2016 1:29

Steps to reproduce

  • Open terminal in OS X, with "Basic" (default) color schema.
  • Run powershell
  • run throw "foo"

Expected behavior

Colors look ok

Actual behavior

Colors don't look ok

image

Environment data

v0.4.0

cc @nanalakshmanan

Copied from original issue: PowerShell/PowerShell#1036

@lzybkr
Copy link
Member Author

@lzybkr lzybkr commented Nov 9, 2016

From @vors on June 9, 2016 22:12

It's not only OS X actually.

This is from Ubuntu Server 14.04, terminal emulator with default colors

image

@lzybkr
Copy link
Member Author

@lzybkr lzybkr commented Nov 9, 2016

From @vors on June 10, 2016 0:55

This is unacceptable

image

@lzybkr
Copy link
Member Author

@lzybkr lzybkr commented Nov 9, 2016

From @joeyaiello on June 27, 2016 19:8

There's two issues here:

  • There's some non-PSReadline code that's overriding the background color of errors. We may want to remove this code now that PSReadline is the engine for changing colors.
  • PSReadline should have proper theme support (with at least light and dark themes, but potentially a host of others).
@lzybkr
Copy link
Member Author

@lzybkr lzybkr commented Nov 9, 2016

From @twblalock on August 18, 2016 20:25

I'm able to set some of the colors on Mac OS, but the names of commands as I type them out remain yellow no matter what.

@lzybkr
Copy link
Member Author

@lzybkr lzybkr commented Nov 4, 2017

Dupe of #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.