From 4353aa4fb3fd76d6577bf94cf6d78c846fe05bd7 Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 11:52:02 -0400 Subject: [PATCH 01/10] Find should only have ValueFromPipeline on Name property --- src/code/FindPSResource.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/code/FindPSResource.cs b/src/code/FindPSResource.cs index 464fddc3d..6dea7f3e3 100644 --- a/src/code/FindPSResource.cs +++ b/src/code/FindPSResource.cs @@ -41,7 +41,6 @@ public sealed class FindPSResource : PSCmdlet /// [Parameter(Position = 0, ValueFromPipeline = true, - ValueFromPipelineByPropertyName = true, ParameterSetName = ResourceNameParameterSet)] [ValidateNotNullOrEmpty] public string[] Name { get; set; } From cba2acd2dc7f4e6c74b6f1802f56db686cd841c2 Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 11:52:55 -0400 Subject: [PATCH 02/10] Get should only have ValueFromPipeline on Name property --- src/code/GetInstalledPSResource.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/code/GetInstalledPSResource.cs b/src/code/GetInstalledPSResource.cs index 34ac306d1..dfcd7202b 100644 --- a/src/code/GetInstalledPSResource.cs +++ b/src/code/GetInstalledPSResource.cs @@ -30,7 +30,7 @@ public sealed class GetInstalledPSResource : PSCmdlet /// /// Specifies the desired name for the resource to look for. /// - [Parameter(Position = 0, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true)] + [Parameter(Position = 0, ValueFromPipeline = true)] public string[] Name { get; set; } /// From 014686f226e8eb3876f3ead5613bdc0b1eabfdbe Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 11:55:43 -0400 Subject: [PATCH 03/10] Publish should not have ValueFromPipeline on any property --- src/code/PublishPSResource.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/code/PublishPSResource.cs b/src/code/PublishPSResource.cs index 5684bfc08..5d7c13176 100644 --- a/src/code/PublishPSResource.cs +++ b/src/code/PublishPSResource.cs @@ -48,7 +48,7 @@ public sealed class PublishPSResource : PSCmdlet /// Specifies the path to the resource that you want to publish. This parameter accepts the path to the folder that contains the resource. /// Specifies a path to one or more locations. Wildcards are permitted. The default location is the current directory (.). /// - [Parameter(Mandatory = true, Position = 0, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true, ParameterSetName = "PathParameterSet")] + [Parameter(Mandatory = true, Position = 0, ParameterSetName = "PathParameterSet")] [ValidateNotNullOrEmpty] public string Path { @@ -80,7 +80,7 @@ public string Path /// No characters are interpreted as wildcards. If the path includes escape characters, enclose them in single quotation marks. /// Single quotation marks tell PowerShell not to interpret any characters as escape sequences. /// - [Parameter(Mandatory = true, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true, ParameterSetName = "PathLiteralParameterSet")] + [Parameter(Mandatory = true, ParameterSetName = "PathLiteralParameterSet")] [ValidateNotNullOrEmpty] public string LiteralPath { @@ -118,7 +118,7 @@ public string LiteralPath /// /// Specifies a proxy server for the request, rather than a direct connection to the internet resource. /// - [Parameter(ValueFromPipelineByPropertyName = true)] + [Parameter()] [ValidateNotNullOrEmpty] public Uri Proxy { set @@ -135,7 +135,7 @@ public Uri Proxy { /// /// Specifies a user account that has permission to use the proxy server that is specified by the Proxy parameter. /// - [Parameter(ValueFromPipelineByPropertyName = true)] + [Parameter()] [ValidateNotNullOrEmpty] public PSCredential ProxyCredential { set @@ -163,7 +163,7 @@ public PSCredential ProxyCredential { protected override void BeginProcessing() { // Create a respository story (the PSResourceRepository.xml file) if it does not already exist - // This is to create a better experience for those who have just installed v3 and want to get up and running quickly + // This is to create a better experience for those who have just installed v3 and want to get up and running quickly RepositorySettings.CheckRepositoryStore(); } From 99f4f19bf3c69471b8d18976dcb5a8f6ac98f03d Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 11:58:48 -0400 Subject: [PATCH 04/10] Register should not have ValueFromPipeline on any property --- src/code/RegisterPSResourceRepository.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/code/RegisterPSResourceRepository.cs b/src/code/RegisterPSResourceRepository.cs index be8173488..2bab73b01 100644 --- a/src/code/RegisterPSResourceRepository.cs +++ b/src/code/RegisterPSResourceRepository.cs @@ -20,8 +20,7 @@ namespace Microsoft.PowerShell.PowerShellGet.Cmdlets [Cmdlet(VerbsLifecycle.Register, "PSResourceRepository", DefaultParameterSetName = NameParameterSet, - SupportsShouldProcess = true, - HelpUri = "")] + SupportsShouldProcess = true)] public sealed class RegisterPSResourceRepository : PSCmdlet { @@ -63,7 +62,7 @@ class RegisterPSResourceRepository : PSCmdlet /// /// Specifies a hashtable of repositories and is used to register multiple repositories at once. /// - [Parameter(Mandatory = true, ParameterSetName = "RepositoriesParameterSet", ValueFromPipeline = true)] + [Parameter(Mandatory = true, ParameterSetName = RepositoriesParameterSet)] [ValidateNotNullOrEmpty] public Hashtable[] Repositories {get; set;} From e25c91b3cac358676156d89d1d498e01c690bbd6 Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 12:00:00 -0400 Subject: [PATCH 05/10] remove unused directive for Register --- src/code/RegisterPSResourceRepository.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/code/RegisterPSResourceRepository.cs b/src/code/RegisterPSResourceRepository.cs index 2bab73b01..678c6fb95 100644 --- a/src/code/RegisterPSResourceRepository.cs +++ b/src/code/RegisterPSResourceRepository.cs @@ -5,7 +5,6 @@ using System; using System.Collections; using System.Collections.Generic; -using System.Globalization; using System.Management.Automation; using Dbg = System.Diagnostics.Debug; From 7ad4dda668d8843f8991e73aec753cc0fa63c193 Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 12:02:08 -0400 Subject: [PATCH 06/10] Set-PSResourceRepository should have ValueFromPipeline only on Name property --- src/code/SetPSResourceRepository.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/code/SetPSResourceRepository.cs b/src/code/SetPSResourceRepository.cs index 284a27e7e..d74507f6b 100644 --- a/src/code/SetPSResourceRepository.cs +++ b/src/code/SetPSResourceRepository.cs @@ -5,7 +5,6 @@ using System.Collections; using System.Collections.Generic; using Dbg = System.Diagnostics.Debug; -using System.Globalization; using System.Management.Automation; using Microsoft.PowerShell.PowerShellGet.UtilClasses; @@ -17,8 +16,7 @@ namespace Microsoft.PowerShell.PowerShellGet.Cmdlets [Cmdlet(VerbsCommon.Set, "PSResourceRepository", DefaultParameterSetName = NameParameterSet, - SupportsShouldProcess = true, - HelpUri = "")] + SupportsShouldProcess = true)] public sealed class SetPSResourceRepository : PSCmdlet { @@ -35,8 +33,7 @@ class SetPSResourceRepository : PSCmdlet /// /// Specifies the name of the repository to be set. /// - [Parameter(Mandatory = true, Position = 0, ValueFromPipeline = true, - ValueFromPipelineByPropertyName = true, ParameterSetName = NameParameterSet)] + [Parameter(Mandatory = true, Position = 0, ValueFromPipeline = true, ParameterSetName = NameParameterSet)] [ArgumentCompleter(typeof(RepositoryNameCompleter))] [ValidateNotNullOrEmpty] public string Name { get; set; } @@ -51,7 +48,7 @@ class SetPSResourceRepository : PSCmdlet /// /// Specifies a hashtable of repositories and is used to register multiple repositories at once. /// - [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RepositoriesParameterSet)] + [Parameter(Mandatory = true, ParameterSetName = RepositoriesParameterSet)] [ValidateNotNullOrEmpty] public Hashtable[] Repositories { get; set; } From 14d3f277309145ae2329d9cb6cff42b65d9365fd Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 12:06:54 -0400 Subject: [PATCH 07/10] Unregister-PSResourceRepository should have ValueFromPipelineByPropertyName for Name param --- src/code/UnregisterPSResourceRepository.cs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/code/UnregisterPSResourceRepository.cs b/src/code/UnregisterPSResourceRepository.cs index 10a15896f..de17bc4eb 100644 --- a/src/code/UnregisterPSResourceRepository.cs +++ b/src/code/UnregisterPSResourceRepository.cs @@ -14,8 +14,7 @@ namespace Microsoft.PowerShell.PowerShellGet.Cmdlets [Cmdlet(VerbsLifecycle.Unregister, "PSResourceRepository", - SupportsShouldProcess = true, - HelpUri = "")] + SupportsShouldProcess = true)] public sealed class UnregisterPSResourceRepository : PSCmdlet { @@ -25,7 +24,6 @@ class UnregisterPSResourceRepository : PSCmdlet /// Specifies the desired name for the repository to be registered. /// [Parameter(Mandatory= true, Position = 0, - ValueFromPipeline = true, ValueFromPipelineByPropertyName = true)] [ArgumentCompleter(typeof(RepositoryNameCompleter))] [ValidateNotNullOrEmpty] From 1b925110e057e2e4dcd8f9b79f210f9f00d64234 Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 12:23:06 -0400 Subject: [PATCH 08/10] Get and Set should have appropriate ValueFromPipeline attributes for Name param --- src/code/GetPSResourceRepository.cs | 2 +- src/code/UnregisterPSResourceRepository.cs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/code/GetPSResourceRepository.cs b/src/code/GetPSResourceRepository.cs index 310549f69..990f19274 100644 --- a/src/code/GetPSResourceRepository.cs +++ b/src/code/GetPSResourceRepository.cs @@ -28,7 +28,7 @@ class GetPSResourceRepository : PSCmdlet /// Specifies the name(s) of a registered repository to find. /// Supports wild card characters. /// - [Parameter(Position = 0, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true)] + [Parameter(Position = 0, ValueFromPipeline = true)] [ArgumentCompleter(typeof(RepositoryNameCompleter))] [ValidateNotNullOrEmpty] public string[] Name { get; set; } = Utils.EmptyStrArray; diff --git a/src/code/UnregisterPSResourceRepository.cs b/src/code/UnregisterPSResourceRepository.cs index de17bc4eb..ea490494e 100644 --- a/src/code/UnregisterPSResourceRepository.cs +++ b/src/code/UnregisterPSResourceRepository.cs @@ -23,8 +23,7 @@ class UnregisterPSResourceRepository : PSCmdlet /// /// Specifies the desired name for the repository to be registered. /// - [Parameter(Mandatory= true, Position = 0, - ValueFromPipelineByPropertyName = true)] + [Parameter(Mandatory= true, Position = 0, ValueFromPipelineByPropertyName = true)] [ArgumentCompleter(typeof(RepositoryNameCompleter))] [ValidateNotNullOrEmpty] public string[] Name { get; set; } = Utils.EmptyStrArray; From 0bea4c72af818b7cbbc9ccf96066650ad04cedbf Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 12:36:59 -0400 Subject: [PATCH 09/10] remove help url --- src/code/GetPSResourceRepository.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/code/GetPSResourceRepository.cs b/src/code/GetPSResourceRepository.cs index 990f19274..82fdeed5d 100644 --- a/src/code/GetPSResourceRepository.cs +++ b/src/code/GetPSResourceRepository.cs @@ -17,8 +17,7 @@ namespace Microsoft.PowerShell.PowerShellGet.Cmdlets /// [Cmdlet(VerbsCommon.Get, - "PSResourceRepository", - HelpUri = "")] + "PSResourceRepository")] public sealed class GetPSResourceRepository : PSCmdlet { From a9b7ed9a687311205cdb4a2fde6e90bd358a6d8a Mon Sep 17 00:00:00 2001 From: Anam Navied Date: Wed, 13 Oct 2021 16:20:09 -0400 Subject: [PATCH 10/10] add ValueFromPipeline for Unregister --- src/code/UnregisterPSResourceRepository.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/code/UnregisterPSResourceRepository.cs b/src/code/UnregisterPSResourceRepository.cs index ea490494e..2d984fc12 100644 --- a/src/code/UnregisterPSResourceRepository.cs +++ b/src/code/UnregisterPSResourceRepository.cs @@ -23,7 +23,7 @@ class UnregisterPSResourceRepository : PSCmdlet /// /// Specifies the desired name for the repository to be registered. /// - [Parameter(Mandatory= true, Position = 0, ValueFromPipelineByPropertyName = true)] + [Parameter(Mandatory= true, Position = 0, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true)] [ArgumentCompleter(typeof(RepositoryNameCompleter))] [ValidateNotNullOrEmpty] public string[] Name { get; set; } = Utils.EmptyStrArray;