From 588dff61a1be9aa3e6d36cd8b19b0b10aa8e0140 Mon Sep 17 00:00:00 2001
From: Jordan Borean <jborean93@gmail.com>
Date: Tue, 16 Apr 2024 03:34:52 +1000
Subject: [PATCH] Fix the error when using `Start-Process -Credential` without
 the admin privilege (#21393)

---
 .../commands/management/Process.cs               | 16 +++++++++++++++-
 .../resources/ProcessResources.resx              |  3 +++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
index 197e3662c25b..73f00b5acc6c 100644
--- a/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
+++ b/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
@@ -2109,7 +2109,21 @@ protected override void BeginProcessing()
                 //   "Process was not started by this object, so requested information cannot be determined."
                 // Fetching the process handle will trigger the `Process` object to update its internal state by calling `SetProcessHandle`,
                 // the result is discarded as it's not used later in this code.
-                _ = process.Handle;
+                try
+                {
+                    _ = process.Handle;
+                }
+                catch (Win32Exception e)
+                {
+                    // If the caller was not an admin and the process was started with another user's credentials .NET
+                    // won't be able to retrieve the process handle. As this is not a critical failure we treat this as
+                    // a warning.
+                    if (PassThru)
+                    {
+                        string msg = StringUtil.Format(ProcessResources.FailedToCreateProcessObject, e.Message);
+                        WriteDebug(msg);
+                    }
+                }
 
                 // Resume the process now that is has been set up.
                 processInfo.Resume();
diff --git a/src/Microsoft.PowerShell.Commands.Management/resources/ProcessResources.resx b/src/Microsoft.PowerShell.Commands.Management/resources/ProcessResources.resx
index a6f6d286dbed..b4c1ddbccf8b 100644
--- a/src/Microsoft.PowerShell.Commands.Management/resources/ProcessResources.resx
+++ b/src/Microsoft.PowerShell.Commands.Management/resources/ProcessResources.resx
@@ -189,6 +189,9 @@
   <data name="CannotStarttheProcess" xml:space="preserve">
     <value>This command cannot be run completely because the system cannot find all the information required.</value>
   </data>
+  <data name="FailedToCreateProcessObject" xml:space="preserve">
+    <value>Failed to retrieve the new process handle: "{0}". The Process object outputted may have some properties and methods that do not work properly.</value>
+  </data>
   <data name="InvalidUserError" xml:space="preserve">
     <value>This command cannot be run due to error 1783. The possible cause of this error can be using of a non-existing user "{0}". Please give a valid user and run your command again.</value>
   </data>