New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSVersionTable needs an *OS* key #1997

Closed
Jaykul opened this Issue Aug 21, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@Jaykul
Copy link

Jaykul commented Aug 21, 2016

We need to be able to at least tell whether we're on Windows or Unix from the PSVersionTable.

Ideally, I'd like to be able to differentiate Windows Server, Windows Desktop, Nano Server, OS X, and BSD from Linux.

Since PSEdition Core runs on Windows (and even Windows Desktop), and since CLRVersion will presumably be the same across all versions of Core (even if it were populated #1984), and since "BuildVersion" is going backwards ...

I also think that PSVersionTable should expose "Architecture" (ARM, AMD64, x86).

@kilasuit

This comment has been minimized.

Copy link
Contributor

kilasuit commented Aug 21, 2016

Agreed and suggested this in #1936 as well as a change to the Issue template to make issues easier to track

@rkeithhill

This comment has been minimized.

Copy link
Contributor

rkeithhill commented Aug 21, 2016

It would make for a nice way to gather information for a bug report. I like. And on Linux, you probably want the specific version i.e. not just Ubuntu but something to distinguish between 14.04 and 16.04. Also, Architecture needs to disambiguate between OS architecture and current process architecture e.g. PowerShell x86 running on Windows x64.

@lzybkr

This comment has been minimized.

Copy link
Member

lzybkr commented Aug 21, 2016

Dupe of #1635.

@Jaykul

This comment has been minimized.

Copy link

Jaykul commented Aug 21, 2016

Sorry. I couldn't find it (searching for PSVersionTable is pointless in here)

@MaximoTrinidad

This comment has been minimized.

Copy link

MaximoTrinidad commented Aug 22, 2016

I agree!
+1 for Jaykul

@lzybkr

This comment has been minimized.

Copy link
Member

lzybkr commented Aug 22, 2016

No problem, I opened it, so I knew it was there. I did search for PSVersionTable first, way too many hits, so added OS and many fewer hits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment