Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFormat-Hex should not try to render unicode control characters that affect the display #7777
Comments
SteveL-MSFT
added
Up-for-Grabs
Area-Cmdlets-Utility
labels
Sep 13, 2018
This comment has been minimized.
This comment has been minimized.
|
Is "`u{00}" expected output format? |
This comment has been minimized.
This comment has been minimized.
|
Any unprintable character (beyond the control characters) should be replaced with the box with question mark symbol. |
This comment has been minimized.
This comment has been minimized.
|
@iSazonov I think @SteveL-MSFT means this one:
|
This comment has been minimized.
This comment has been minimized.
|
@ThreeFive-O Thanks for clarify. Will this symbol be well displayed in the Windows 7 console with default config? |
This comment has been minimized.
This comment has been minimized.
|
With Raster fonts (default on Windows 7) the replacement symbol is not displayed. It does not look good. |
This comment has been minimized.
This comment has been minimized.
|
We might have to special case Win7 and do something like detect if the font can display and and maybe just show a question mark. |
This comment has been minimized.
This comment has been minimized.
|
Determining the capabilities of a font at runtime looks impossible. |
This comment has been minimized.
This comment has been minimized.
|
@iSazonov does U+FFFD render as whitespace on Win7? That might be good enough since the telemetry shows that only a minor % of customers are on Win7 and it's probably a small set of those customers using format-hex. |
This comment has been minimized.
This comment has been minimized.
Raster font is default on Windows 7 console and the symbol is displayed as whitespace. User have to select TrueType font to see the symbol. I personally always do this. Also I tried |
SteveL-MSFT
added
the
First-Time-Issue
label
Jan 1, 2019
This comment has been minimized.
This comment has been minimized.
|
I think this should be pretty straight forward as I expect the unicode control characters to be documented on the internet and just needs to be added to the already existing filter out list |
SteveL-MSFT commentedSep 13, 2018
Format-Hex currently filters out control characters in the ASCII range that would affect the console display. Needs to be updated to handle Unicode control characters. Also consider replacing use of period for non-printable characters with the Unicode symbol for non-printable to avoid confusion with actual periods.