pwsh -Login support #10050

rjmholt · 2019-07-02T23:18:10Z

PR Summary

Adds support for the -Login flag to PowerShell, execs /bin/sh to run the login profile, which then execs PowerShell.

PR Context

This implements PowerShell/PowerShell-RFC#186.

Fix #975

The startup performance can be profiled with the script here.

Some implementation details:

The argument parsing for this is done as early as possible
This passes the arguments through exec and through /bin/sh (/bin/bash on macOS) with "$@"
I've tried to avoid any allocation or other unneccessary computations, but there might be other opportunities to improve

NOTE: This supersedes -LoadProfile, which is a breaking change, but of a feature that only exists in preview (and is for the same use case as -Login).

PR Checklist

ExE-Boss · 2019-07-04T03:29:20Z

I don’t think we need to remove ‑LoadProfile, we’ll just need to change the abbreviation to something like ‑lp.

This is so that we can override an alias that passes -NoProfile.

src/powershell/Program.cs

rjmholt · 2019-07-04T03:54:13Z

I don’t think we need to remove ‑LoadProfile, we’ll just need to change the abbreviation to something like ‑lp.

This is so that we can override an alias that passes -NoProfile.

-LoadProfile was only added to be compatible with -Login and was supposed to be a no-op, but was actually more confusingly order dependent. I personally don't think it's really something we want in PowerShell, and I think we should try to keep exe options to a minimum

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs

src/powershell/Program.cs

iSazonov · 2019-07-04T13:16:55Z

src/powershell/Program.cs

+            string pwshInvocation = string.Create(
+                10 + quotedPwshPathLength, // exec '{pwshPath}' "$@"
+                (pwshPath, quotedPwshPathLength),
+                CreatePwshInvocation);


I wonder that we do the optimization (and others) if we fork.

Not sure I follow you here -- can you rephrase maybe?

All the code run only once - no need to optimize something. I think we get more short and readable code if we will use classic string operations and string.Format.

Right, the merits of various optimisations are dubious since we are just trying to exec as quickly as possible, which will then overwrite the whole process.

But I'm assuming that calls to things like malloc and the possibility of GC are still things we want to avoid. Similarly, if string formatting is handled by complex code in another assembly, I'd prefer to hardcode the small case here in an attempt to do our best to execute only the IL we know about here.

src/powershell/Program.cs

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs

SteveL-MSFT · 2019-07-08T16:06:48Z

@rjmholt please make corresponding doc change for PS7 and link to this PR

src/powershell/Program.cs

rjmholt · 2019-07-08T18:03:24Z

https://github.com/MicrosoftDocs/PowerShell-Docs/pull/4528/files

src/powershell/Program.cs

andyleejordan · 2019-07-09T01:32:51Z

@rjmholt 🥇

rjmholt · 2019-07-09T02:05:14Z

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs

                {
                    _showHelp = true;
                    _showExtendedHelp = true;
                    _abortStartup = true;
                }
+                else if (MatchSwitch(switchKey, "login", "l"))


Ideally we should move this to the bottom, since the check will never succeed and all switches below it will check this first.

But I left it here because of alpha ordering and also because I feel like it might be worth doing a wider investigation of the switch detection logic for startup performance.

iSazonov

I think all native code must be in PowerShell-Native as C code. Really we need 2 function - IsAlreadyLoginShell() and IsLoginArgumentPresent().
It simplify code in the repo and C code will be simple too. And it will be fastest.

Also the code in PowerShell Native could help us to resolve #3322 with additional GetCommandLine() function.

src/powershell/Program.cs

daxian-dbw · 2019-08-08T19:29:29Z

Spoke to @daxian-dbw offline about p/invokes vs native code. We agreed that the current implementation is good enough for now and we want to investigate moving the underlying logic into PSNative for performance benefits

Yes, talked with Rob on this. P/Invoke itself is expensive, plus Jitting the P/Invoke code possibly will be more expensive than non-P/Invoke code.
By moving some of the P/Invoke heavy code (e.g. the code to get the first byte of the executable name and the executable path) to native code and simply calling one P/Invoke from managed code to get what we need would be more efficient.
But that can happen in a follow-up PR, not this one.

See PInvoke Performance Considerations:

PInvoke has an overhead of between 10 and 30 x86 instructions per call. In addition to this fixed cost, marshaling creates additional overhead. There is no marshaling cost between blittable types that have the same representation in managed and unmanaged code. For example, there is no cost to translate between int and Int32.

For better performance, have fewer PInvoke calls that marshal as much data as possible, instead of more calls that marshal less data per call.

rjmholt · 2019-08-08T21:12:08Z

I've amended the logic here to only recognise -Login when it's the first argument. This is so we don't have to reimplement all of argument parsing at this early stage. When we work on a native implementation, we can have a look at whether improving that is feasible.

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs

daxian-dbw

LGTM

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs

daxian-dbw · 2019-08-08T22:06:42Z

@PoshChan please retry static

PoshChan · 2019-08-08T22:07:03Z

@daxian-dbw, successfully started retry of PowerShell-CI-static-analysis

src/powershell/Program.cs

iSazonov · 2019-08-09T04:25:29Z

src/powershell/Program.cs

+        /// <returns>
+        /// An exit code if exec failed, but if successful the calling process will be overwritten.
+        /// </returns>
+        [DllImport("libc",


Please use const for "libc".

SteveL-MSFT

You'll probably also need to update your docs PR to reflect that -l must be first

src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx

daxian-dbw · 2019-08-14T18:11:59Z

@SteveL-MSFT Can you please take another look to see if you are OK with the updates?

anmenaga · 2019-08-14T20:18:33Z

No blocking issues; merging so it would get into next release.

ghost · 2019-08-20T22:37:13Z

🎉v7.0.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

* Build(deps): Bump Microsoft.PowerShell.Archive from 1.2.2.0 to 1.2.3.0 in /src/Modules (PowerShell#9593) * Support line continuance with pipe at the start of a line (PowerShell#8938) Expands line continuance for pipelines to allow lines to continue automatically without backticks with the pipe symbol at the start of a line. This adds to the existing functionality where pipes can be used to continue lines by placing them at the end of a line. * Fix use of unicode ellipsis in xml (PowerShell#9589) * Updating committee membership (PowerShell#9577) * Build(deps): Bump System.Data.SqlClient from 4.6.0 to 4.6.1 (PowerShell#9601) * Build(deps): Bump PowerShellGet from 2.1.2 to 2.1.3 in /src/Modules (PowerShell#9600) * Build(deps): Bump Microsoft.Windows.Compatibility from 2.0.1 to 2.1.1 (PowerShell#9605) * Build(deps): Bump NJsonSchema from 9.13.37 to 9.14.1 (PowerShell#9616) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 9.13.37 to 9.14.1. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Convert windows CI to stages (PowerShell#9607) * Switch from BMP to PNG for graphical MSI installer assets (PowerShell#9606) This breaks rendering of images for Windows 7 and Server 2008R2, but it's required for accessibility purposes so that the High Contrast Black theme renders text correctly for accessibility. (Unfortunately, BMP does not support transparency.) * Add checkbox to PR checklist for experimental feature use (PowerShell#9619) * Make sure we always return an object in command searcher (PowerShell#9623) * Remove Workflow from PSSessionType (PowerShell#9618) Remove PSSessionType and IsWorkflowConfigurationType() * Port PowerShell to .NET Core 3.0 (PowerShell#9597) * Attributes.cs - Style / Formatting Fixes (PowerShell#9625) * Update README and metadata.json (PowerShell#9624) * Update version tests to use NextReleaseVersion from metadata.json (PowerShell#9646) * Build(deps): Bump PackageManagement from 1.3.2 to 1.4 in /src/Modules (PowerShell#9650) * Build(deps): Bump PackageManagement from 1.3.2 to 1.4 in /src/Modules Bumps PackageManagement from 1.3.2 to 1.4. Signed-off-by: dependabot[bot] <support@dependabot.com> * Update vNext release branches in dependabot config (PowerShell#9658) * Build(deps): Bump Microsoft.CodeAnalysis.CSharp from 3.0.0 to 3.1.0 (PowerShell#9653) * Disable the debugger when in system lock-down mode (PowerShell#9645) Disable the debugger when in system lock-down mode Fixing master for CVE-2019-0733 * Build(deps): Bump PowerShellGet from 2.1.3 to 2.1.4 in /src/Modules (PowerShell#9691) * Run Start-PSBootStrap in Code Coverage build to install .NET SDK (PowerShell#9690) * Merged PR 8504: Fix syncing modules from powershell gallery by normalizing version numbers Fix syncing modules from powershell gallery by normalizing version numbers and added additional logging. * Fix daily `CodeCoverageAndTest` build by explicitly calling `Start-PSBootStrap` (PowerShell#9724) * Merged PR 8510: Update the target framework for reference assemblies to netcoreapp3.0 Update the target framework for reference assemblies to netcoreapp3.0 * Merged PR 8512: Update version for SDK tests and Microsoft.PowerShell.Native package Update version for SDK tests and Microsoft.PowerShell.Native package * Pin version of netDumbster to 2.0.0.4 (PowerShell#9748) * Update the target framework for reference assemblies to netcoreapp3.0 (PowerShell#9747) Update the target framework for reference assemblies to netcoreapp3.0 * Merged PR 8529: Add cleanup before building test package Add cleanup before building test package * Change log for release 6.2.1 (PowerShell#9760) Changelog for 6.2.1 and fix spellings * Change log 6.1.4 (PowerShell#9759) * Update change log for 6.1.4 Update change log for 6.1.4 * Resolve conflicts * Merged PR 8547: Fix the PowerShell version number in MSI packages Fix the PowerShell version number in MSI packages * Merged PR 8542: changelog draft changelog draft * Update README and metadata.json for 7.0.0-preview.1 release (PowerShell#9767) * Increase timeout of NuGet job to workaround build timeout (PowerShell#9772) * Code Cleanup: Tidy up scriptblock.cs (PowerShell#9732) * Fix `Get-ChildItem -Path` with wildcard char (PowerShell#9257) Unescape non-literal, non-glob path before existence checking. * Build(deps): Bump Microsoft.ApplicationInsights from 2.9.1 to 2.10.0 (PowerShell#9757) * Disable stale bot in favor of an internal bot that we can customize more (PowerShell#9785) * Build(deps): Bump System.Net.Http.WinHttpHandler from 4.5.3 to 4.5.4 (PowerShell#9786) * Use new string.ConCat() in Process.cs (PowerShell#9720) * Build(deps): Bump NJsonSchema from 9.14.1 to 10.0.13 (PowerShell#9805) * Support negative numbers in `-split` operator (PowerShell#8960) * Fix use of `Start-Process http://bing.com` (PowerShell#9793) * Improve whitespace for Parser tests (PowerShell#9806) * Build(deps): Bump NJsonSchema from 10.0.13 to 10.0.14 (PowerShell#9843) * Fix minor style issues come from last commits (PowerShell#9640) * Support DSC compilation on Linux. (PowerShell#9834) * Build(deps): Bump NJsonSchema from 10.0.14 to 10.0.15 (PowerShell#9854) * Have console host not enter command prompt mode when using `Read-Host -Prompt` (PowerShell#9743) `Read-Host` calls into `$Host.UI.Prompt()`. However, this method is also used when the host prompts for mandatory parameters that aren't provided. The method expects to be called when given a `FieldDescription` and if the input starts with `!` it enters `CommandPromptMode`. In this mode, you can type `!?` to request help, for example. However this mode is not something you can use via `Read-Host` (only if calling `$Host.UI.Prompt()` directly passing in a well constructed `FieldDescription`). When using `Read-Host -Prompt`, the cmdlet creates a `FieldDescription` where the name is the prompt and the rest of the properties are empty. The fix is that if `Label` is empty, we can assume it's being called from `Read-Host` rather than being called to prompt for a mandatory parameter and thus not enter `CommandPromptMode`. * Add ability to pass `InitialSessionState` to the `ConsoleShell.Start` (PowerShell#9802) * Build(deps): Bump NJsonSchema from 10.0.15 to 10.0.17 (PowerShell#9862) * Add launchSettings.json for better out of box experience when using Visual Studio (PowerShell#9818) * Build(deps): Bump NJsonSchema from 10.0.17 to 10.0.18 (PowerShell#9875) * Add module to support Pester tests for automating debugger commands (stepInto, stepOut, etc.), along with basic tests (PowerShell#9825) * Build(deps): Bump NJsonSchema from 10.0.18 to 10.0.19 (PowerShell#9885) * Make `UseAbbreviationExpansion` and `TempDrive` official features (PowerShell#9872) * Attempt to work around the zip download issue in Azure DevOps Windows CI (PowerShell#9911) * Fix unix project mappings (PowerShell#9892) * Update to use TSAv2 (PowerShell#9914) * Use yarn to install global tools (PowerShell#9904) * Build(deps): Bump PackageManagement from 1.4 to 1.4.1 in /src/Modules (PowerShell#9820) Bumps PackageManagement from 1.4 to 1.4.1. * Build(deps): Bump PackageManagement from 1.4.1 to 1.4.2 in /src/Modules (PowerShell#9918) * Import-DscResource should allow to overwrite DSC built-in resources. (PowerShell#9879) * Use the original precision (prior-dotnet-core-3) for double/fload-to-string conversion (PowerShell#9893) .NET Core changes to return "shortest roundtrippable string" by default for the ToString() method of double and float types. This results in ToString() for double/float values sometimes return a string in 17-digit/9-digit precision format. This PR updated the double/float-to-string conversion in PowerShell to continue using the old precision specifier before the change in .NET Core 3.0. * Build(deps): Bump PowerShellGet from 2.1.4 to 2.1.5 in /src/Modules (PowerShell#9933) Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.1.4 to 2.1.5. - [Release notes](https://github.com/PowerShell/PowerShellGet/releases) - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/development/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Clean up the use of 'SetProfileRoot' and 'StartProfile' in ConsoleHost (PowerShell#9931) * Clean up the use of 'SetProfileRoot' and 'StartProfile' in ConsoleHost * Remove 'pwsh.pdb' from our component file list * Update console startup and help url for PowerShell docs (PowerShell#9775) * Fix minor CodeFactor style issues in ModuleCmdletBase (PowerShell#9915) * Build(deps): Bump NJsonSchema from 10.0.19 to 10.0.20 (PowerShell#9954) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 10.0.19 to 10.0.20. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Style fixes for CimAsyncOperations (PowerShell#9945) * Improve release testing Docker images (PowerShell#9942) * Remove some Travis-CI references (PowerShell#9919) * Fix minor typos in code comments (PowerShell#9917) * Indentation fixes in ci.psm1 (PowerShell#9947) * Update readme gitter badge (PowerShell#9920) * Display com method signature with argument names (PowerShell#9858) * Display Duration when displaying `HistoryInfo` (PowerShell#9751) * Remove dead code about 'IsTransparentProxy' (PowerShell#9966) * Fix style issues from last commits (PowerShell#9937) * Suppress sporadic exceptions from JumpList creation code (PowerShell#9928) * Remove EtwActivity empty constructor and make minor style fixes (PowerShell#9958) * Sync docs changes into the embedded help for pwsh (PowerShell#9952) * Fix amazonlinux install script (PowerShell#9967) * Fix wrong comparison in CertificateProvider (PowerShell#9987) * Cleanup Parser tests (PowerShell#9792) Co-Authored-By: Ilya <darpa@yandex.ru> * Remove LCIDToLocaleName P/Invoke from GetComputerInfoCommand (PowerShell#9716) - Remove LCIDToLocaleName P/Invoke with StringBuilder - Reduce allocations by using GetCultureInfo to get cached CultureInfo - Use UInt32.TryParse to parse Hex - Minor cleanups after above changes * Fix gulp versions (PowerShell#9916) * Add quick steps for adding docs to cmdlets (PowerShell#9978) * Cleanup: Use EndsWith(char) and StartsWith(char) (PowerShell#9994) * Add test for `New-Item -Force` (PowerShell#9971) * Allow methods to be named after keywords (PowerShell#9812) * Move consts and methods to single CharExtensions class (PowerShell#9992) * Build(deps): Bump ThreadJob from 1.1.2 to 2.0.1 in /src/Modules (PowerShell#10003) * Code cleanup: use IndexOf(char) overload (PowerShell#9722) - Use IndexOf(char) overload instead of IndexOf(string) to benefit from Ordinal search - Replace IndexOf with Contains to get more understandable code - Use StringComparison.Ordinal for ASCII chars * Add automated RPM signing to release build (PowerShell#10013) * Download latest version (6.2.0) of PSDesiredStateConfiguration nuget package. (PowerShell#9932) * Update copyright symbol for NuGet packages (PowerShell#9936) * Avoid the `int[]` and `int[,]` allocation when tokenizing line comments and matching wildcard pattern (PowerShell#10009) - Reusing the same 2-dimensional integer array for processing line comments in the same Tokenizer. - Use ArrayPool<int> in PatternPositionVisitor to avoid creating transient int[]. * Bump NJsonSchema from 10.0.20 to 10.0.21 (PowerShell#10017) Bumps [NJsonSchema](https://github.com/rsuter/NJsonSchema) from 10.0.20 to 10.0.21. - [Release notes](https://github.com/rsuter/NJsonSchema/releases) - [Commits](https://github.com/rsuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Consider `DBNull.Value` and `NullString.Value` the same as `$null` when comparing with `$null` and casting to bool (PowerShell#9794) - Adds `LanguagePrimitives.IsNullLike()` method to account for `DBNull.Value` and `NullString.Value` so that they can be considered the same as a null value where sensible in PowerShell. - Updates `-ne` and `-eq` binders to treat `DBNull.Value` and `NullString.Value` as equal to null/AutomationNull. - Update code paths for comparing objects in LanguagePrimitives to ensure consistency with how the `-eq` and `-ne` binders work when calling LanguagePrimitives methods to do the comparisons. - Make `LanguagePrimitives.IsNull()` and `LanguagePrimitives.IsNullLike()` public methods. - Added tests for null behaviours in `NullRepresentatives.Tests.ps1` * Start-PSBuild -Clean doeas not remove all untracked files (PowerShell#10022) * Avoid `Assembly.GetName()` in 'ClrFacade.GetAssemblies(string)' to reduce allocations of 'CultureInfo' objects (PowerShell#10024) * Use AddRange in GetModules() (PowerShell#9975) * Add fast path for wildcard patterns that contains no wildcard characters (PowerShell#10020) * Set request headers when request body is empty in Web Cmdlets (PowerShell#10034) * Suppress PossibleIncorrectUsageOfAssignmentOperator rule violation by adding extra parenthesis (PowerShell#9460) * Use `AddOrUpdate()` instead of `Remove` then `Add` to register runspace (PowerShell#10007) * Reduce allocations in NavigationCmdletProvider.NormalizePath() (PowerShell#10038) * Indent fix in markdown-link.tests.ps1 (PowerShell#10049) * Use a static cache for `PSVersionInfo.PSVersion` to avoid casting `SemanticVersion` to `Version` very time accessing that property (PowerShell#10028) * Bump Markdig.Signed from 0.17.0 to 0.17.1 (PowerShell#10062) * Cleanup workflow code (PowerShell#9638) * Remove WorkFlowInfo type * Remove condition for UseSharedProcess * Remove PSWorkflowJob condition * Remove workflow from ValidateSet * Remove workflow from CommandTypes enum * Remove workflow from EventManager * Remove workflow from Get-Help * Remove WorkflowFileExtension ".xaml" from ModuleIntrinsics * Remove WorkflowFileExtension ".xaml" from ModuleCmdletBase * Remove workflow from PSModuleInfo * Remove workflow from CustomShellCommands * Remove workflow from InitialSessionStateProvider * Remove WriteWorkflowDebugNotSupportedError() * Remove unneeded resource strings from Module.cs * Remove xaml from valid extension list * Add to /etc/shells on macOS (PowerShell#10066) Co-Authored-By: Robert Holt <rjmholt@gmail.com> * Check if a reparsepoint is a symlink before trying to get target (PowerShell#9895) * Make `Foreach-Object` 2 times faster by reducing unnecessary allocations and boxing (PowerShell#10047) * Update 'Start-PSBuild -Clean' logic of 'git clean' to ignore locked files from VS2019 (PowerShell#10071) * Create JumpList in STA thread as some COM APIs are strictly STA only to avoid sporadic CLR crashes (PowerShell#10057) * Upgrade .Net Core 3 SDK from preview5 to preview6 and related out of band Nuget packages from 2.1 to 3.0-preview6 (PowerShell#9888) * Bump PackageManagement from 1.4.2 to 1.4.3 in /src/Modules (PowerShell#10084) Bumps PackageManagement from 1.4.2 to 1.4.3. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * add performance tag to change log command * Bump PowerShellGet from 2.1.5 to 2.2 in /src/Modules (PowerShell#10085) Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.1.5 to 2.2. - [Release notes](https://github.com/PowerShell/PowerShellGet/releases) - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/development/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Move some of the creations of `WildcardPattern` in outer loop to avoid unnecessary allocation (PowerShell#10053) * Add another fast path to `WildcardPattern.IsMatch` for patterns that only have an asterisk in the end (PowerShell#10054) * Update change log generation tool to deal with private commits (PowerShell#10096) * Bump System.Text.Encoding.CodePages (PowerShell#10112) Bumps System.Text.Encoding.CodePages from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.AccessControl (PowerShell#10100) Bumps System.Security.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Threading.AccessControl (PowerShell#10106) Bumps System.Threading.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Data.SqlClient (PowerShell#10109) Bumps System.Data.SqlClient from 4.7.0-preview6.19303.8 to 4.7.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Management (PowerShell#10110) Bumps System.Management from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.DirectoryServices (PowerShell#10105) Bumps System.DirectoryServices from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.Cryptography.Pkcs (PowerShell#10107) Bumps System.Security.Cryptography.Pkcs from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.IO.Packaging (PowerShell#10108) Bumps System.IO.Packaging from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.Principal.Windows (PowerShell#10101) Bumps System.Security.Principal.Windows from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Security.AccessControl (PowerShell#10102) Bumps System.Security.AccessControl from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump System.Configuration.ConfigurationManager (PowerShell#10111) Bumps System.Configuration.ConfigurationManager from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Add -SecurityDescriptorSddl parameter to Set-Service (PowerShell#8626) * Bump System.Text.Encodings.Web (PowerShell#10123) Bumps System.Text.Encodings.Web from 4.6.0-preview6.19303.8 to 4.6.0-preview.19113.10. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Revert "Bump System.IO.Packaging (PowerShell#10108)" (PowerShell#10125) This reverts commit 45edbd7. * Revert "Bump System.Data.SqlClient (PowerShell#10109)" (PowerShell#10126) This reverts commit 83d8ec4. * Revert "Bump System.Threading.AccessControl (PowerShell#10106)" (PowerShell#10127) This reverts commit a7f0c6d. * Revert "Bump System.Text.Encodings.Web (PowerShell#10123)" (PowerShell#10124) This reverts commit b9501d9. * Revert "Bump System.Management (PowerShell#10110)" (PowerShell#10129) This reverts commit e5990ed. * Revert "Bump System.Security.Cryptography.Pkcs (PowerShell#10107)" (PowerShell#10130) This reverts commit d33c906. * Revert "Bump System.Text.Encoding.CodePages (PowerShell#10112)" (PowerShell#10131) This reverts commit 958cdda. * Revert "Bump System.Security.AccessControl (PowerShell#10102)" (PowerShell#10132) This reverts commit 729a29a. * Revert "Bump System.Configuration.ConfigurationManager (PowerShell#10111)" (PowerShell#10128) This reverts commit c8fe894. * Revert "Bump System.Security.Principal.Windows (PowerShell#10101)" (PowerShell#10133) This reverts commit f75c635. * Cleanup workflow - remove PSProxyJob (PowerShell#10083) * Revert "Bump System.DirectoryServices (PowerShell#10105)" (PowerShell#10135) This reverts commit 2852efc. # Conflicts: # src/System.Management.Automation/System.Management.Automation.csproj * Fix test password generation rule to meet Windows complexity requirements (PowerShell#10143) * Cleanup CompiledScriptBlock.cs (PowerShell#9735) * Add alias for Service 'StartType' (PowerShell#9940) * Mark Set-Service tests with password as `Pending` (PowerShell#10146) * Split the fxdependent package on Windows into two packages (PowerShell#10134) * Remove 'kill' alias for Stop-Process cmdlet on Unix (PowerShell#10098) * Identify renaming a parameter set as non-breaking in the breaking change contract document (PowerShell#10113) * Identify renaming a parameter set as non-breaking Related discussion: PowerShell#10058. * Add note about S.M.A.Internal * Update DotNet Support links (PowerShell#10145) * Remove `markdownlint` tests due to security issues (PowerShell#10163) * Remove `markdownlint` tests due to security issues (PowerShell#10163) * Merged PR 5767: Fix RegEx DoS issues Fix RegEx DoS issues * Skip `JumpList` on `NanoServer` and `IoT` (PowerShell#10164) * Skip `JumpList` on `NanoServer` and `IoT` (PowerShell#10164) * Merged PR 9185: Update PowerShell SDK version for hosting tests Update PowerShell SDK version for hosting tests * Merged PR 9168: Disable Enter-PSHostProcess cmdlet when system in lock down mode This is based on an issue, where Enter-PSHostProcess on a locked down (WDAC enforced) machine allows any admin to connect to any another local hosted PowerShell process and execute commands as that user. This amounts to privilege escalation on the policy locked down machine and something we want to prevent. Fix is to check for system lock down and disable Enter-PSHostProcess cmdlet with an error message. * Update README.md and metadata.json for next releases (PowerShell#10087) * Add tooling section to PR template (PowerShell#10144) * Add .devcontainer configuration (PowerShell#10114) * Add the license header to `nanoserver.tests.ps1` (PowerShell#10171) * Refactor security policy documentation so that they appear in the Security policy tab of GitHub (PowerShell#9905) Co-Authored-By: Travis Plunk <travis.plunk@microsoft.com> * PSSA also includes formatting (PowerShell#10172) * Merged PR 9166: Update changelog for v7.0.0-preview.2 Update changelog for v7.0.0-preview.2 Updates are expected when STA / MTA change comes in. * Fix hungarian prefix 'my' (PowerShell#9976) * Update docs for `7.0.0-preview.2` release (PowerShell#10160) * Update release date for `v7.0.0-preview.2` (PowerShell#10176) * Reduce allocations in Escape() and Unescape() (PowerShell#10041) * Add -Raw switch to Select-String for convenience (PowerShell#9901) * Avoid boxing when passing value type arguments to `PSTraceSource.WriteLine` (PowerShell#10052) * Fix macOS build break (PowerShell#10207) * Use nameof() in LocationGlobber and PathInfo (PowerShell#10200) * Use nameof() in LocationGlobber * Use nameof() in PathInfo * Fix: Removed dependency file with Dependabot (PowerShell#10212) * Enable `-sta` and `-mta` switches for pwsh (PowerShell#10061) * Use 'Platform.IsWindowsDesktop' instead of checking both NanoServer and IoT (PowerShell#10205) * Special case the posix locale in WildcardPattern (PowerShell#10186) * Quote arguments in `.vscode/tasks.json` in case of spaces (PowerShell#10204) * Create`Distribution_Request` issue template (PowerShell#10253) * Fix spelling error in issue template (PowerShell#10256) * Revert the temporary change (PowerShell#10260) * Bump Microsoft.CodeAnalysis.CSharp from 3.1.0 to 3.2.0 (PowerShell#10273) Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Cleanup: ThreadAbortException is now in .Net Core 3.0 (PowerShell#10230) * Cleanup: ThreadAbortException is now in .Net Core 3.0 * Fix CodeFactor issue * Remove ThreadAbortException * Remove ThreadAbortException relared code * Remove stable and servicing branches from dependabot (PowerShell#10289) * Update dead links from powershell.com (PowerShell#10297) * Remove extra check that the system dll exists (PowerShell#10244) * Update PowerShell to build against .NET Core 3.0-preview7 (PowerShell#10227) * Fix debugger disable performance regression (PowerShell#10269) * Don't collect process starttime as it's not being used on consolehost startup (PowerShell#10294) * mark _readyForInputTimeInMS member as part of LEGACYTELEMETRY * move _interactiveCommandCount to LEGACYTELEMETRY * Cleanup Docker release testing (PowerShell#10310) * Update our language on our policy applying to security issues (PowerShell#10304) * Add tests for WildcardPattern.Escape() and Unescape() (PowerShell#10090) * Update 'Microsoft.PowerShell.CoreCLR.Eventing' to resolve conflict with 'System.Diagnostics.EventLog' (PowerShell#10305) * Update 'Microsoft.PowerShell.CoreCLR.Eventing' to resolve conflicts * Add reference to 'System.Diagnostics.EventLog' to build Microsoft.PowerShell.Commands.Diagnostics on Unix * Stop compiling Get/New-WinEvent on Unix * Enable Experimental Features by default on Preview builds (PowerShell#10228) * Bump Microsoft.CodeAnalysis.CSharp from 3.2.0 to 3.2.1 (PowerShell#10330) Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 3.2.0 to 3.2.1. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Expose PreRelease label in PSModuleInfo formatter (PowerShell#10316) * Reduce allocations in MakePath() method (PowerShell#10027) * Add `Microsoft.PowerShell.CoreCLR.Eventing.dll` to exception list for build fix (PowerShell#10337) * Add dispose of _runspaceDebugCompleteEvent event object. (PowerShell#10323) * Make module name matching for `get-module -FullyQualifiedName`… (PowerShell#10329) * Fix `#requires -version` for pwsh 7 to include 6.1 and 6.2 in `PSCompatibleVersions` (PowerShell#9943) * Implement ForEach-Object -Parallel feature (PowerShell#10229) * Add support for AppX reparse points (PowerShell#10331) * Make Get-DscResource work with class based resources (PowerShell#10350) * pwsh -Login support (PowerShell#10050) * Deprecate internal HelpCategory.Workflow enumeration (PowerShell#10319) * Fix style issues in InternalCommands.cs (PowerShell#10352) * Deprecate workflow debugging code (PowerShell#10321) * Bump NJsonSchema from 10.0.21 to 10.0.22 (PowerShell#10364) Bumps [NJsonSchema](https://github.com/RicoSuter/NJsonSchema) from 10.0.21 to 10.0.22. - [Release notes](https://github.com/RicoSuter/NJsonSchema/releases) - [Commits](https://github.com/RicoSuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Move to .NET Core 3.0 preview.8 (PowerShell#10351) * Update Microsoft.Management.Infrastructure version to 2.0.0-preview.2 (PowerShell#10366) * Mark `-parallel` and `-throttlelimit` reserved for `foreach` and `switch` statements (PowerShell#10328) * Fix minor breakpoint re-hydration bug (PowerShell#10339) * Additional Telemetry - Implementation of `RFC0036` (PowerShell#10336) * Formatting: Handle `XTPUSHSGR` and `XTPOPSGR` control sequences (PowerShell#10208) * .CPL should be added to PATHEXT (PowerShell#9828) * Add experimental check for `ForEach-Object -Parallel` tests (PowerShell#10354) * Bump `PackageManagement` from `1.4.3` to `1.4.4` (PowerShell#10383) Bumps PackageManagement from 1.4.3 to 1.4.4. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump PowerShellGet from 2.2 to 2.2.1 in /src/Modules (PowerShell#10382) Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.2 to 2.2.1. - [Release notes](https://github.com/PowerShell/PowerShellGet/releases) - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/development/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Merged PR 9744: Update changelog for preview.3 release Update changelog for preview.3 release * Update `README.md` and `metadata.json` for `7.0.0-preview.3` (PowerShell#10393) * Add `PSKoans` to Learning Resources documentation (PowerShell#10369) * Add some regular contributors to allow access to retry CI (PowerShell#10397) * Some dependencies for Alpine need `linux-x64` folder (PowerShell#10407) * Block type update in Add-Type cmdlet (PowerShell#9609) * Increase built-with-PowerShell module versions to 7.0.0.0 (PowerShell#10356) * Rename default ParameterSetName back to `Delimiter` for `ConvertTo-Csv` & `ConvertFrom-Csv` (PowerShell#10425) * rename default parameterset name back to `Delimiter` * also fix convertfrom-csv * rename parametersetname for UseCulture back to UseCulture since there is no path for ConvertFrom-Csv * Skip auto-loading PSReadLine on Windows if the NVDA screen reader is active (PowerShell#10385) * Bump NJsonSchema from 10.0.22 to 10.0.23 (PowerShell#10421) Bumps [NJsonSchema](https://github.com/RicoSuter/NJsonSchema) from 10.0.22 to 10.0.23. - [Release notes](https://github.com/RicoSuter/NJsonSchema/releases) - [Commits](https://github.com/RicoSuter/NJsonSchema/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Add support to `ActionPreference.Break` to break into debugger (PowerShell#8205) * Alpine validation changes (PowerShell#10428) * Remove yet another appveyor reference (PowerShell#10445) * Update the combined package build to release the daily builds (PowerShell#10449) * Cleanup `AutomationEngine` and remove extra `SetSessionStateDrive` method call (PowerShell#10416) * Make sure the daily coordinated build, knows it is a daily bui… (PowerShell#10464) * Minor fix for recursion into OneDrive - Change FindFirstFileEx() to use SafeFindHandle type (PowerShell#10405) * Update README.md (PowerShell#10465) Fix typo. * Make `ForEach-Object` faster for its commonly used scenarios (PowerShell#10454) * Fix global tool issues around exit code, command line parameters and path with spaces (PowerShell#10461)

rjmholt requested review from anmenaga and daxian-dbw as code owners July 2, 2019 23:18

ExE-Boss reviewed Jul 4, 2019

View reviewed changes

src/powershell/Program.cs Show resolved Hide resolved

rjmholt changed the title ~~WIP: pwsh -Login support~~ pwsh -Login support Jul 4, 2019

rjmholt mentioned this pull request Jul 4, 2019

Enable use of pwsh as login shell PowerShell/PowerShell-RFC#186

Merged

iSazonov reviewed Jul 4, 2019

View reviewed changes

ExE-Boss reviewed Jul 4, 2019

View reviewed changes

src/powershell/Program.cs Show resolved Hide resolved

SteveL-MSFT assigned anmenaga Jul 5, 2019

rjmholt force-pushed the exec-login branch from 5020bcb to de9e81b Compare July 8, 2019 15:21

PoshChan reviewed Jul 8, 2019

View reviewed changes

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs Show resolved Hide resolved

SteveL-MSFT requested changes Jul 8, 2019

View reviewed changes

src/powershell/Program.cs Outdated Show resolved Hide resolved

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jul 8, 2019

rjmholt requested review from SteveL-MSFT and JamesWTruher July 8, 2019 18:14

sdwheeler mentioned this pull request Jul 8, 2019

Add pwsh -Login to docs MicrosoftDocs/PowerShell-Docs#4528

Merged

9 tasks

SteveL-MSFT requested changes Jul 8, 2019

View reviewed changes

src/powershell/Program.cs Show resolved Hide resolved

src/powershell/Program.cs Show resolved Hide resolved

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jul 8, 2019

rjmholt commented Jul 8, 2019

View reviewed changes

src/powershell/Program.cs Outdated Show resolved Hide resolved

rjmholt force-pushed the exec-login branch from b86ef4d to 3a46ca0 Compare July 9, 2019 00:40

joeyaiello mentioned this pull request Jul 9, 2019

Unix usability problems #1390

Closed

11 tasks

rjmholt commented Jul 9, 2019

View reviewed changes

iSazonov mentioned this pull request Jul 11, 2019

PowerShell should support inheritance of default shell environment variables as a default shell #975

Closed

iSazonov reviewed Jul 12, 2019

View reviewed changes

src/powershell/Program.cs Outdated Show resolved Hide resolved

src/powershell/Program.cs Outdated Show resolved Hide resolved

src/powershell/Program.cs Outdated Show resolved Hide resolved

src/powershell/Program.cs Outdated Show resolved Hide resolved

Amend login logic to read only first argument

07e248c

PoshChan reviewed Aug 8, 2019

View reviewed changes

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs Show resolved Hide resolved

PoshChan reviewed Aug 8, 2019

View reviewed changes

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs Show resolved Hide resolved

daxian-dbw and others added 2 commits August 8, 2019 14:33

Update a stale comment about exec -a

1d8e1c5

Update tests

da0f75f

daxian-dbw approved these changes Aug 8, 2019

View reviewed changes

PoshChan reviewed Aug 8, 2019

View reviewed changes

src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs Show resolved Hide resolved

iSazonov reviewed Aug 9, 2019

View reviewed changes

SteveL-MSFT requested changes Aug 9, 2019

View reviewed changes

src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx Outdated Show resolved Hide resolved

src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx Show resolved Hide resolved

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Aug 9, 2019

Address remaining comments

4b1f521

SteveL-MSFT approved these changes Aug 14, 2019

View reviewed changes

anmenaga merged commit 14960b5 into PowerShell:master Aug 14, 2019

iSazonov mentioned this pull request Aug 15, 2019

Additional Telemetry - Implementation of RFC0036 #10336

Merged

14 tasks

TravisEz13 added this to the 7.0.0-preview.3 milestone Aug 16, 2019

bfloch mentioned this pull request Aug 29, 2019

Enhancements for shell plugins AcademySoftwareFoundation/rez#698

Merged

11 tasks

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Sep 14, 2019

pwsh -Login support (PowerShell#10050)

e93ed65

sdwheeler mentioned this pull request Oct 24, 2019

Document PowerShell as my default login shell MicrosoftDocs/PowerShell-Docs#4991

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pwsh -Login support #10050

pwsh -Login support #10050

rjmholt commented Jul 2, 2019 •

edited

ExE-Boss commented Jul 4, 2019 •

edited

rjmholt commented Jul 4, 2019

iSazonov Jul 4, 2019

rjmholt Jul 5, 2019

iSazonov Jul 5, 2019

rjmholt Jul 8, 2019

SteveL-MSFT commented Jul 8, 2019

rjmholt commented Jul 8, 2019

andyleejordan commented Jul 9, 2019

rjmholt Jul 9, 2019

iSazonov left a comment •

edited

daxian-dbw commented Aug 8, 2019 •

edited

rjmholt commented Aug 8, 2019

daxian-dbw left a comment

daxian-dbw commented Aug 8, 2019

PoshChan commented Aug 8, 2019

iSazonov Aug 9, 2019

SteveL-MSFT left a comment

daxian-dbw commented Aug 14, 2019

anmenaga commented Aug 14, 2019

ghost commented Aug 20, 2019

pwsh -Login support #10050

pwsh -Login support #10050

Conversation

rjmholt commented Jul 2, 2019 • edited

PR Summary

PR Context

PR Checklist

ExE-Boss commented Jul 4, 2019 • edited

rjmholt commented Jul 4, 2019

iSazonov Jul 4, 2019

Choose a reason for hiding this comment

rjmholt Jul 5, 2019

Choose a reason for hiding this comment

iSazonov Jul 5, 2019

Choose a reason for hiding this comment

rjmholt Jul 8, 2019

Choose a reason for hiding this comment

SteveL-MSFT commented Jul 8, 2019

rjmholt commented Jul 8, 2019

andyleejordan commented Jul 9, 2019

rjmholt Jul 9, 2019

Choose a reason for hiding this comment

iSazonov left a comment • edited

Choose a reason for hiding this comment

daxian-dbw commented Aug 8, 2019 • edited

rjmholt commented Aug 8, 2019

daxian-dbw left a comment

Choose a reason for hiding this comment

daxian-dbw commented Aug 8, 2019

PoshChan commented Aug 8, 2019

iSazonov Aug 9, 2019

Choose a reason for hiding this comment

SteveL-MSFT left a comment

Choose a reason for hiding this comment

daxian-dbw commented Aug 14, 2019

anmenaga commented Aug 14, 2019

ghost commented Aug 20, 2019

rjmholt commented Jul 2, 2019 •

edited

ExE-Boss commented Jul 4, 2019 •

edited

iSazonov left a comment •

edited

daxian-dbw commented Aug 8, 2019 •

edited