New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSIX packaging to determine if a Preview release by inspecting the semantic version string #11991
Conversation
…e semantic version string
@@ -3049,7 +3049,7 @@ function New-MSIXPackage | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/ADOPTERS.md.https://shell.azure.com/ should work
Failed to complete request to "https://shell.azure.com/". Response status code does not indicate success: 500 (Internal Server Error).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119: throw "Failed to complete request to `"$url`". $($_.Exception.Message)"
@PoshChan please retry static, macos |
@adityapatwardhan, successfully started retry of |
@PoshChan retry static |
@SteveL-MSFT, successfully started retry of |
@PoshChan retry static |
@SteveL-MSFT, successfully started retry of |
🎉 Handy links: |
…e semantic version string (#11991)
🎉 Handy links: |
PR Summary
The non-Preview release still gets a Product Name of "PowerShell Preview" because the code was looking to see if the
$productname
contains a-
. Since the version is added after the product name, it will always have a-
such aspowershell-7.0.0
. The fix is to only look for the-
within the semantic version string like7.0.0-rc.1
.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.