Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSIX packaging to determine if a Preview release by inspecting the semantic version string #11991

Merged
merged 1 commit into from Mar 5, 2020

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Mar 2, 2020

PR Summary

The non-Preview release still gets a Product Name of "PowerShell Preview" because the code was looking to see if the $productname contains a -. Since the version is added after the product name, it will always have a - such as powershell-7.0.0. The fix is to only look for the - within the semantic version string like 7.0.0-rc.1.

PR Checklist

@@ -3049,7 +3049,7 @@ function New-MSIXPackage

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/ADOPTERS.md.https://shell.azure.com/ should work

Failed to complete request to "https://shell.azure.com/". Response status code does not indicate success: 500 (Internal Server Error).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

@adityapatwardhan
Copy link
Member

@PoshChan please retry static, macos

@PoshChan
Copy link
Collaborator

PoshChan commented Mar 2, 2020

@adityapatwardhan, successfully started retry of PowerShell-CI-static-analysis, PowerShell-CI-macOS

@SteveL-MSFT
Copy link
Member Author

@PoshChan retry static

@PoshChan
Copy link
Collaborator

PoshChan commented Mar 2, 2020

@SteveL-MSFT, successfully started retry of PowerShell-CI-static-analysis

@SteveL-MSFT
Copy link
Member Author

@PoshChan retry static

@PoshChan
Copy link
Collaborator

PoshChan commented Mar 3, 2020

@SteveL-MSFT, successfully started retry of PowerShell-CI-static-analysis

@anmenaga anmenaga merged commit 268afbd into PowerShell:master Mar 5, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2020
@adityapatwardhan adityapatwardhan added this to the 7.1.0-preview.1 milestone Mar 24, 2020
@msftbot
Copy link

msftbot bot commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@msftbot
Copy link

msftbot bot commented Jan 19, 2021

🎉v7.0.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.0.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants