Network share path expansion should support forward slashes

[sba923]

Summary of the new feature / enhancement

As a user using the French keyboard layout, entering a forward slash (Shift+:) is way more convenient than entering a backslash (AltGr+8). So using forward slashes throughout PowerShell has become muscle memory...

This works in most cases.

Alas, tab expansion for inputs like

\\hostname\x<TAB>

works, but this doesn't:

//hostname/x<TAB>

Proposed technical implementation details (optional)

No response

[MartinGC94]

This is handled here: https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs#L4304 at a glance, it looks like a relatively simple thing to fix.

GitHub

PowerShell/CompletionCompleters.cs at master · PowerShell/PowerShell

PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

[sba923]

Had almost found it 😆, now I need to remember how to build the repo and will give it a shot!

[sba923]

Tomorrow is another day 😜

[SeeminglyScience]

@sba923 You just wanna add -ResGen

[sba923]

@sba923 You just wanna add -ResGen

Thx.

Build still emits this error... after producing pwsh.exe:

With this change, the expected result seems to be achieved (though the completion turns the forward slashes into backslashes, but that's OK):

Is that good enough or would you consider optimizing the regex?

[sba923]

Is adding this comment OK? What's the preferred way of referring to issues? Absolute GH URL or #nnnnn?

// support both / and \ when entering UNC paths for typing convenience (#17111)

[SeeminglyScience]

Build still emits this error... after producing pwsh.exe:

Yeah I dunno what's up with that but I get it too so 🤷

Is that good enough or would you consider optimizing the regex?

That can be settled in the review. I would recommend making it a literal (@"pattern here") instead though so it's somewhat feasible to read 😁 (I know it was like that before, but while we're there might as well).

Is adding this comment OK? What's the preferred way of referring to issues? Absolute GH URL or #nnnnn?

I think that's good, but also can be settled in the review if needed.

[sba923]

OK. This works fine, so I'll proceed with creating the PR:

[sba923]

PR #17117 created. Was not completely sure about the "impacts completers" section of the checklist, though.

[ghost]

🎉This issue was addressed in #17117, which has now been successfully released as v7.3.0-preview.4.:tada:

Handy links:

• Release Notes

[ghost]

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes