New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected use of PSModulePath casing to be consistent with Windows PowerShell #3255

Merged
merged 4 commits into from Mar 15, 2017

Conversation

Projects
None yet
5 participants
@SteveL-MSFT
Member

SteveL-MSFT commented Mar 4, 2017

addresses #3227

Show outdated Hide outdated test/powershell/engine/Remoting/SessionOption.Tests.ps1
function Get-PassedArgsRoot { [Root]::new().passedIn }
$passedArgs = $args
class Root { $passedIn = $passedArgs }
function Get-PassedArgsRoot { [Root]::new().passedIn }

This comment has been minimized.

@iSazonov

iSazonov Mar 5, 2017

Collaborator

What's changed?

@iSazonov

iSazonov Mar 5, 2017

Collaborator

What's changed?

This comment has been minimized.

@SteveL-MSFT

SteveL-MSFT Mar 6, 2017

Member

Didn't change anything here as PSModulePath isn't here. Not sure why this is showing up in the PR as a change.

@SteveL-MSFT

SteveL-MSFT Mar 6, 2017

Member

Didn't change anything here as PSModulePath isn't here. Not sure why this is showing up in the PR as a change.

This comment has been minimized.

@SteveL-MSFT

SteveL-MSFT Mar 6, 2017

Member

Don't see any whitespace difference either

@SteveL-MSFT

SteveL-MSFT Mar 6, 2017

Member

Don't see any whitespace difference either

addressing review feedback
make "PSModulePath" into const
fixed some test workarounds due to failures for external reasons that wasn't meant to be checked in

SteveL-MSFT added some commits Mar 6, 2017

addressing review feedback
make "PSModulePath" into const
fixed some test workarounds due to failures for external reasons that wasn't meant to be checked in
@SteveL-MSFT

This comment has been minimized.

Show comment
Hide comment
@SteveL-MSFT
Member

SteveL-MSFT commented Mar 15, 2017

@TravisEz13 merge?

@TravisEz13 TravisEz13 merged commit 76de340 into PowerShell:master Mar 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

BrucePay added a commit to BrucePay/PowerShell that referenced this pull request Mar 17, 2017

corrected use of PSModulePath casing to be consistent with Windows Po…
…werShell (#3255)

* corrected use of PSModulePath casing to be consistent with Windows PowerShell
addresses #3227

* addressing review feedback
make "PSModulePath" into const
fixed some test workarounds due to failures for external reasons that wasn't meant to be checked in

* addressing review feedback
make "PSModulePath" into const
fixed some test workarounds due to failures for external reasons that wasn't meant to be checked in

@SteveL-MSFT SteveL-MSFT deleted the SteveL-MSFT:psmodulepath branch Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment