New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed drifting of progress bar on Unix #3289

Merged
merged 1 commit into from Mar 11, 2017

Conversation

Projects
None yet
4 participants
@SteveL-MSFT
Member

SteveL-MSFT commented Mar 8, 2017

progress bar was incorrectly setting the original x position which causes the progress to slowly move to the right in certain cases

addresses #3202

need some suggestions on how to add a test for this

progress bar was incorrectly setting the original x position which ca…
…uses the progress to slowly move to the right in certain cases

addresses #3202

@SteveL-MSFT SteveL-MSFT requested a review from lzybkr Mar 9, 2017

@lzybkr lzybkr self-assigned this Mar 9, 2017

@lzybkr

lzybkr approved these changes Mar 9, 2017

I'm not sure it's worth adding a test for this.

The code doesn't change frequently, and it's difficult to test.

@SteveL-MSFT

This comment has been minimized.

Show comment
Hide comment
@SteveL-MSFT

SteveL-MSFT Mar 9, 2017

Member

@lzybkr it's also something easily noticed by people using PowerShell if it's not working :)

Member

SteveL-MSFT commented Mar 9, 2017

@lzybkr it's also something easily noticed by people using PowerShell if it's not working :)

@daxian-dbw daxian-dbw merged commit 9c40d29 into PowerShell:master Mar 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

BrucePay added a commit to BrucePay/PowerShell that referenced this pull request Mar 17, 2017

Fix drifting of progress bar on Unix (#3289)
The progress bar was incorrectly setting the original x position which causes the progress to slowly move to the right in certain cases

@SteveL-MSFT SteveL-MSFT deleted the SteveL-MSFT:progressbar branch Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment