updated doc to build arm/arm64 versions of psrp.windows library #5668
Conversation
docs/building/internals.md
Outdated
| The `x64_arm` and `x64_arm64` architectures mean that the host system needs to be x64 to cross-compile to ARM. | ||
| When building for multiple architectures, be sure to use the `-clean` switch as cmake will cache the previous run and the wrong compiler will be used to generate the subsequent architecutes. | ||
|
|
||
| After that, the binary `pwrshplugin.dll` and its PDB file will be placed under 'src\powershell-native\bin\release\coreclr'. |
There was a problem hiding this comment.
Maybe we should use the path 'src\powershell-win-core' here. The dll and pdb files will be bin-placed to "src\powershell-win-core" (see the script), and it's the same to 'PowerShell.Core.Instrumentation.dll' which will also be produced when running Start-BuildNativeWindowsBinaries.
docs/building/internals.md
Outdated
| \---native | ||
| pwrshplugin.dll | ||
| pwrshplugin.pdb | ||
| ``` | ||
|
|
||
| Lastly, run `nuget pack .` from within the folder. Note that you may need the latest `nuget.exe`. | ||
| Have the dlls signed and run `nuget pack` from the parent of the `runtimes` folder where `psrp.windows.nuspec` resides. |
There was a problem hiding this comment.
Have the dlls signed
Please add "with authenticode dual certificate"
|
@SteveL-MSFT I just released we don't have arm32/arm64 version of Can we build |
|
@daxian-dbw I'll publish a new pkg for those dlls |
|
I'll merge the psrp.windows and powershell.core.instrumentation sections into a general Windows native section |
address PR feedback merge PowerShell.Core.Instrumentation section into PSRP.Windows section
…l.Core.Instrumentation.dll libraries (#5668)
…l.Core.Instrumentation.dll libraries (#5668)
PR Summary
The doc to build and publish psrp.windows library needed to be updated to support arm and arm64 builds. It was also missing steps for signing and publishing. Added details on individual features needed for VS2017 and location to publish on MyGet.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.