Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Format-Hex #8683

Merged
merged 2 commits into from Jan 18, 2019

Conversation

@vexx32
Copy link
Contributor

commented Jan 18, 2019

PR Summary

Cleanup for code style prior to #8674

/cc @iSazonov ❤️

PR Context

Format-Hex can use a little love in the style department. Added some XML comments that were missing, tidied up existing ones, and made sure the code style overall is consistent with how we've been doing in recent PRs according to StyleCop and other linters.

PR Checklist

@vexx32 vexx32 requested review from JamesWTruher and PaulHigin as code owners Jan 18, 2019


offset += bytesRead;
}
}
}
catch (IOException ioException)
catch (IOException fileException)

This comment has been minimized.

Copy link
@iSazonov

iSazonov Jan 18, 2019

Collaborator

It is not always true :-) Please revert.

This comment has been minimized.

Copy link
@vexx32

vexx32 Jan 18, 2019

Author Contributor

CodeFactor complained that the io prefix looks too much like a Hungarian prefix, from memory. Is this simply not a concern?

This comment has been minimized.

Copy link
@iSazonov

iSazonov Jan 18, 2019

Collaborator

We frequently use catch (IOException e).
(I guess we will disable the check.)

@iSazonov iSazonov requested a review from SteveL-MSFT Jan 18, 2019

@iSazonov iSazonov self-assigned this Jan 18, 2019

@daxian-dbw
Copy link
Member

left a comment

LGTM. Thanks @vexx32 !

@iSazonov iSazonov merged commit 631833c into PowerShell:master Jan 18, 2019

6 checks passed

CodeFactor 21 issues fixed.
Details
PowerShell-CI-linux #PR-8683-20190118.02 succeeded
Details
PowerShell-CI-macos #PR-8683-20190118.02 succeeded
Details
PowerShell-CI-windows #PR-8683-20190118.02 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details

@iSazonov iSazonov changed the title Cleanup: Format-Hex Cleanup Format-Hex Jan 18, 2019

@vexx32 vexx32 deleted the vexx32:Style/FormatHex branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.