Build Global tool for PowerShell and SDK container #8984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Feb 26, 2019
| [Parameter(Mandatory)] $DestinationPath | ||
| ) | ||
| ## Remove unnecessary files | ||
| $localeFolderToRemove = 'cs', 'de', 'es', 'fr', 'it', 'ja', 'ko', 'pl', 'pt-BR', 'ru', 'tr', 'zh-Hans', 'zh-Hant' |
There was a problem hiding this comment.
What if there will new folder? Maybe not "remove" but "use/filter only necessary folder"?
There was a problem hiding this comment.
Can I take this as a bug fix after this PR?
TravisEz13
reviewed
Feb 26, 2019
TravisEz13
reviewed
Feb 26, 2019
TravisEz13
approved these changes
Feb 26, 2019
adityapatwardhan
requested review from
anmenaga and
daxian-dbw
as code owners
iSazonov
added
the
CL-Tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR builds a unified global tool to support all the runtimes as well as two separate reduced size global tools to be included in dotnet sdk container images.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests