Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename private methods in MshCommandRuntime.cs #9074

Merged
merged 1 commit into from Mar 8, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -249,7 +249,7 @@ public void WriteObject(object sendToPipeline, bool enumerateCollection)

#if CORECLR
// SecurityContext is not supported in CoreCLR
DoWriteObjects(sendToPipeline);
DoWriteEnumeratedObject(sendToPipeline);
#else
if (UseSecurityContextRun)
{
@@ -278,11 +278,11 @@ public void WriteObject(object sendToPipeline, bool enumerateCollection)
/// <exception cref="System.InvalidOperationException">
/// Not permitted at this time or from this thread
/// </exception>
private void DoWriteObjects(object sendToPipeline)
private void DoWriteEnumeratedObject(object sendToPipeline)
{
// NOTICE-2004/06/08-JonN 959638
ThrowIfWriteNotPermitted(true);
_WriteObjectsSkipAllowCheck(sendToPipeline);
_EnumerateAndWriteObjectSkipAllowCheck(sendToPipeline);
}
// Trust: public void WriteObject(object sendToPipeline, DataTrustCategory trustCategory); // enumerateCollection defaults to false
// Trust: public void WriteObject(object sendToPipeline, bool enumerateCollection, DataTrustCategory trustCategory);
@@ -2591,7 +2591,7 @@ internal void _WriteObjectSkipAllowCheck(object sendToPipeline)
/// The Cmdlet should generally just allow PipelineStoppedException
/// to percolate up to the caller of ProcessRecord etc.
/// </exception>
internal void _WriteObjectsSkipAllowCheck(object sendToPipeline)
internal void _EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)

This comment has been minimized.

Copy link
@iSazonov

iSazonov Mar 6, 2019

Collaborator
Suggested change
internal void _EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)
internal void EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)

This comment has been minimized.

Copy link
@vexx32

vexx32 Mar 6, 2019

Author Contributor

If I go that route it might be better to just rename half the things in this file, in all honesty... There are a lot of similarly questionable names here.

This comment has been minimized.

Copy link
@iSazonov

iSazonov Mar 6, 2019

Collaborator

Oh, no. It is better to spend time to create something useful.

This comment has been minimized.

Copy link
@vexx32

vexx32 Mar 6, 2019

Author Contributor

I'll come back to it when I'm really bored and do a proper style pass over the whole thing. 😉

Not a big-ticket item, but there's a lot of room for tidying up in this one. 😄

{
IEnumerable enumerable = LanguagePrimitives.GetEnumerable(sendToPipeline);
if (enumerable == null)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.