Fix UseCorrectCasing to be actually configurable via"powershell.codeFormatting.useCorrectCasing" #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectCasing" was not propagated correctly to PSES
bergmeister
changed the title
4 tasks
|
|
rjmholt
approved these changes
Apr 8, 2019
bergmeister
added a commit
to bergmeister/PowerShellEditorServices
that referenced
this pull request
Apr 9, 2019
…ormatting.useCorrectCasing" (PowerShell#910) * Make UseCorrectCasing configurable as "powershell.codeFormatting.useCorrectCasing" was not propagated correctly to PSES * re-trigger ci * remove global.json
rjmholt
pushed a commit
to rjmholt/PowerShellEditorServices
that referenced
this pull request
Apr 10, 2019
…ormatting.useCorrectCasing" (PowerShell#910) * Make UseCorrectCasing configurable as "powershell.codeFormatting.useCorrectCasing" was not propagated correctly to PSES * re-trigger ci * remove global.json
rjmholt
pushed a commit
that referenced
this pull request
Apr 10, 2019
…ormatting.useCorrectCasing" (#910) * Make UseCorrectCasing configurable as "powershell.codeFormatting.useCorrectCasing" was not propagated correctly to PSES * re-trigger ci * remove global.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
useCorrectCasingsetting configurable by "powershell.codeFormatting.useCorrectCasing". It was correctly sent from the extension but rather hard-coded by accident in PSES, which made it not possible to turn the setting off.This needs to be backported. cc @TylerLeonhardt