Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
I wanted to use SqlSetup to do a version upgrade. This isn't currently supported.
A basic version of it can easily added to MSFT_SqlSetup.psm1:
I tested and this upgrades a basic SQL 2012 install to SQL 2017. This doesn't need to support everything, but supporting something is better than nothing right?
I think this is a bug and it should update the existing rule. The unique factor is the instance name, so if that gets overwritten, it's the correct behaviour.
I'm satisfied the PR works. Here's my functional test suite against my lab.
…1369) - Changes to SqlServerDsc - Update Assert-TestEnvironment.ps1 to not error if strict mode is enabled and there are no missing dependencies (issue #1368). - Changes to SqlSetup - Add an Action type of 'Upgrade'. This will ask setup to do a version upgrade where possible (issue #1368). - Fix an error when testing for DQS installation (issue #1368). - Changes to SqlWindowsFirewall - Where a version upgrade has changed paths for a database engine, the existing firewall rule for that instance will be updated rather than another one created (issue #1368). Other firewall rules can be fixed to work in the same way later. - Changes to SqlAGDatabase - Fix issue where calling Get would return an error because the database name list may have been returned as a string instead of as a string array (issue #1368).