Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerMemory: Localization should change to align with HQRM modules #617

Closed
johlju opened this issue Jun 6, 2017 · 0 comments

Comments

2 participants
@johlju
Copy link
Collaborator

commented Jun 6, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource). More information in PR #205.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added this to Backlog in Localization (HQRM) Jun 6, 2017

@johlju johlju changed the title xSQLServerMemory: Localization should change to align with HQRM modules SqlServerMemory: Localization should change to align with HQRM modules Dec 24, 2017

@johlju johlju added in progress and removed help wanted labels Apr 23, 2019

johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 23, 2019

Changes to SqlServerMemory
- Added en-US localization (issue PowerShell#617).
  - No longer will the resource set the MinMemory value if it was provided
    in a configuration that also set the `Ensure` parameter to 'Absent' (issue PowerShell#1329).
  - Refactored unit tests to simplify them add add slightly more code
    coverage.

johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 25, 2019

Changes to SqlServerMemory
- Added en-US localization (issue PowerShell#617).
  - No longer will the resource set the MinMemory value if it was provided
    in a configuration that also set the `Ensure` parameter to 'Absent' (issue PowerShell#1329).
  - Refactored unit tests to simplify them add add slightly more code
    coverage.

@johlju johlju closed this in #1330 Apr 25, 2019

johlju added a commit that referenced this issue Apr 25, 2019

SqlServerMemory: Localization, unit tests and fix bug (#1330)
- Changes to SqlServerMemory
  - Added en-US localization (issue #617).
  - No longer will the resource set the MinMemory value if it was provided
    in a configuration that also set the `Ensure` parameter to 'Absent' (issue #1329).
  - Refactored unit tests to simplify them add add slightly more code
    coverage.

@kwirkykat kwirkykat removed the in progress label Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.