New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerNetwork: Localization should change to align with HQRM modules #618

Closed
johlju opened this Issue Jun 6, 2017 · 0 comments

Comments

1 participant
@johlju
Contributor

johlju commented Jun 6, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource). More information in PR #205.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added this to Backlog in Localization (HQRM) Jun 6, 2017

@johlju johlju added in progress and removed help wanted labels Oct 15, 2017

@johlju johlju moved this from Backlog to In progress in Localization (HQRM) Oct 15, 2017

@johlju johlju closed this in #887 Oct 17, 2017

johlju added a commit that referenced this issue Oct 17, 2017

BREAKING CHANGE: xSQLServerNetwork: Support for configuring SQL Serve…
…r to use a static port (#887)

- Changes to xSQLServerNetwork
  - BREAKING CHANGE: Renamed parameter TcpDynamicPorts to TcpDynamicPort and
    changed type to Boolean (issue #534).
  - Resolved issue when switching from dynamic to static port.
    configuration (issue #534).
  - Added localization (en-US) for all strings in resource and unit tests
    (issue #618).
  - Updated examples to reflect new parameters.

@johlju johlju moved this from In progress to Done in Localization (HQRM) Oct 18, 2017

@johlju johlju removed the in progress label Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment