New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerSetup: Trailing Slash in UpdatePath #720

Closed
alexjebens opened this Issue Aug 8, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@alexjebens
Contributor

alexjebens commented Aug 8, 2017

Details of the scenario you tried and the problem that is occurring:
I had specified an UpdateSource that contained a trailing slash e.g. "C:\SQL\Updates\".

I then received the error "The /IAcceptSQLServerLicenseTerms command line parameter is missing or has not been set to true."

From what I can tell the xSQLServerSetup is sanitizing all paths in terms of trailing slashes EXCEPT UpdateSource. Should be an easy fix by adding ,'UpdateSource' at line 853 in the resource.
The DSC configuration that is using the resource (as detailed as possible):
UpdatePath = "C:\SQL\Updates\"
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
Win2012R2
SQL2014Dev
WMF5.1
What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
xSqlServer 8.0.0.0
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Main / PSGET

Would be glad to make the contribution

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Aug 10, 2017

Collaborator

@aboersch Thanks for reporting this! And you are correct, it should be sufficient to add this to the array at line 838.

Collaborator

johlju commented Aug 10, 2017

@aboersch Thanks for reporting this! And you are correct, it should be sufficient to add this to the array at line 838.

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Aug 10, 2017

Collaborator

To all: This is an "easy fix", so if anyone want to contribute this change to the module, then this would be a good issue to start with. I'm here to help along the way.

Collaborator

johlju commented Aug 10, 2017

To all: This is an "easy fix", so if anyone want to contribute this change to the module, then this would be a good issue to start with. I'm here to help along the way.

@alexjebens

This comment has been minimized.

Show comment
Hide comment
@alexjebens

alexjebens Aug 11, 2017

Contributor

Me ;)

Contributor

alexjebens commented Aug 11, 2017

Me ;)

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Aug 11, 2017

Collaborator

@aboersch awesome! Labeling this as in progress.

Collaborator

johlju commented Aug 11, 2017

@aboersch awesome! Labeling this as in progress.

@johlju johlju added in progress and removed help wanted labels Aug 11, 2017

alexjebens added a commit to alexjebens/xSQLServer that referenced this issue Sep 4, 2017

@johlju johlju closed this in #723 Sep 4, 2017

johlju added a commit that referenced this issue Sep 4, 2017

xSqlServerSetup: Remove trailing slash from 'UpdateSource' Property (#…
…723)

- Changes to xSQLServer
  - Fixed an issue with trailing slashes in the 'UpdateSource' Property (issue #720).

@johlju johlju removed the in progress label Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment