New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServer: Integration tests should use -ErrorAction Stop on Start-DscConfiguration #824

Closed
johlju opened this Issue Sep 19, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@johlju
Collaborator

johlju commented Sep 19, 2017

Details of the scenario you tried and the problem that is occurring:
If -ErrorAction Stop is not used in integration tests for the cmdlet Start-DscConfiguration some errors does not throw resulting in passing tests (even if errors are logged).

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 19, 2017

Changes to xSQLServer
- Changes to xSQLServerAlwaysOnService
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).
- Changes to xSQLServerSetup
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).

@johlju johlju added in progress and removed help wanted labels Sep 19, 2017

johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 19, 2017

Changes to xSQLServer
- Changes to xSQLServerAlwaysOnService
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).
- Changes to xSQLServerSetup
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).

@johlju johlju closed this in #826 Sep 20, 2017

johlju added a commit that referenced this issue Sep 20, 2017

xSQLServer: Fix integration tests. Added ErrorAction 'Stop' to the cm…
…dlet Start-DscConfiguration (#826)

- Changes to xSQLServerAlwaysOnService
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).
- Changes to xSQLServerSetup
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).

@johlju johlju removed the in progress label Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment