New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example references bad resource names #904

Closed
mgreenegit opened this Issue Nov 9, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@mgreenegit
Member

mgreenegit commented Nov 9, 2017

https://github.com/mgreenegit/SqlServerDsc/blob/dev/Examples/SQL-ClusterDB.ps1

xSQLServerFailoverClusterSetup is not a valid resource name

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Nov 10, 2017

Contributor

The examples in the root of the example folder contain a lot of issues. I'm working on replacing them in issue #462. In that issue my thought was to split them up between xFailoverCluster and xSQLServer repo as examples in a markdown file, trying to link to examples in each resource example folder. Eventually, I want to see these as configurations in DscConfigurations repository.
But step one is remove the obsolete examples from the repo so I can turn on the common example tests instead of the examples compilation test that was added to this repo to be able to verify examples (the common test version is more enhanced at this point).

Since these are considered obsolete, maybe we should push a comment block to them saying so. Keeping this issue open so we can do this change to the examples files before next release.

Contributor

johlju commented Nov 10, 2017

The examples in the root of the example folder contain a lot of issues. I'm working on replacing them in issue #462. In that issue my thought was to split them up between xFailoverCluster and xSQLServer repo as examples in a markdown file, trying to link to examples in each resource example folder. Eventually, I want to see these as configurations in DscConfigurations repository.
But step one is remove the obsolete examples from the repo so I can turn on the common example tests instead of the examples compilation test that was added to this repo to be able to verify examples (the common test version is more enhanced at this point).

Since these are considered obsolete, maybe we should push a comment block to them saying so. Keeping this issue open so we can do this change to the examples files before next release.

johlju added a commit to johlju/SqlServerDsc that referenced this issue Nov 29, 2017

Changes to SqlServerDsc
- The examples in the root of the Examples folder are obsolete. Those examples
  now have a note saying so, in the comment-based help, until they can be replaced (issue PowerShell#904).

@johlju johlju referenced this issue Nov 29, 2017

Merged

SqlServerDsc: Adding note to obsolete examples #920

3 of 5 tasks complete

johlju added a commit to johlju/SqlServerDsc that referenced this issue Nov 30, 2017

Changes to SqlServerDsc
- The examples in the root of the Examples folder are obsolete. Those examples
  now have a note saying so, in the comment-based help, until they can be replaced (issue PowerShell#904).

@johlju johlju closed this in #920 Nov 30, 2017

johlju added a commit that referenced this issue Nov 30, 2017

SqlServerDsc: Adding note to obsolete examples (#920)
- Changes to SqlServerDsc
  - The examples in the root of the Examples folder are obsolete. A note was
    added to the comment-based help in each example stating it is obsolete.
    This is a temporary measure until they are replaced (issue #904).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment