New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: SqlServerDsc: The resource module has been renamed #916

Closed
johlju opened this Issue Nov 28, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@johlju
Contributor

johlju commented Nov 28, 2017

Details of the scenario you tried and the problem that is occurring:
The resource module has been renamed to SqlServerDsc. We should reflect that in the CHANGELOG.md

It was rename as part of issue #851. When that major breaking change was done we took the opportunity to rename the resource module as well.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju changed the title from SqlServerDsc: The resource module has been renamed to BREAKING CHANGE: SqlServerDsc: The resource module has been renamed Nov 28, 2017

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Nov 28, 2017

Contributor

Maybe not a breaking change depending how you look at it, but I will label it so anyway. :)

Contributor

johlju commented Nov 28, 2017

Maybe not a breaking change depending how you look at it, but I will label it so anyway. :)

@johlju johlju closed this in #919 Nov 29, 2017

johlju added a commit that referenced this issue Nov 29, 2017

SqlServerDsc: Fix CHANGELOG.md after resource module rename (#919)
- BREAKING CHANGE: Resource module has been renamed to SqlServerDsc (issue #916).

@johlju johlju removed the in progress label Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment