New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRS: Rename parameters RSSQLServer and RSSQLInstanceName #923

Closed
johlju opened this Issue Dec 1, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@johlju
Contributor

johlju commented Dec 1, 2017

Details of the scenario you tried and the problem that is occurring:
The work renaming parameters in issue #308 does not mention the parameters
RSSQLServer and RSSQLInstanceName in the resource SqlRS.

[Required, Description("Name of the SQL Server to host the Reporting Service database.")] String RSSQLServer;
[Required, Description("Name of the SQL Server instance to host the Reporting Service database.")] String RSSQLInstanceName;

I suggest we rename them to DatabaseServerName and DatabaseInstanceName respectively.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added the discussion label Dec 1, 2017

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Dec 1, 2017

Contributor

@nabrond @randomnote1 another one, what do you think?

Contributor

johlju commented Dec 1, 2017

@nabrond @randomnote1 another one, what do you think?

@johlju johlju changed the title from SqlRS: Rename parameters RSSQLServerand RSSQLInstanceName to SqlRS: Rename parameters RSSQLServer and RSSQLInstanceName Dec 1, 2017

@randomnote1

This comment has been minimized.

Show comment
Hide comment
@randomnote1

randomnote1 Dec 1, 2017

Contributor

Yes, I agree these should be updated for consistency.

Contributor

randomnote1 commented Dec 1, 2017

Yes, I agree these should be updated for consistency.

@nabrond

This comment has been minimized.

Show comment
Hide comment
@nabrond

nabrond Dec 2, 2017

Contributor

Concur.

Contributor

nabrond commented Dec 2, 2017

Concur.

@johlju johlju added in progress and removed help wanted labels Dec 5, 2017

@johlju

This comment has been minimized.

Show comment
Hide comment
@johlju

johlju Dec 5, 2017

Contributor

Working on this.

Contributor

johlju commented Dec 5, 2017

Working on this.

johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 5, 2017

Changes to SqlRS
- BREAKING CHANGE: Parameters RSSQLServer and RSSQLInstanceName has been renamed
  to DatabaseServerName and DatabaseInstanceName respectively (issue PowerShell#923).

@johlju johlju closed this in #932 Dec 6, 2017

johlju added a commit that referenced this issue Dec 6, 2017

BREAKING CHANGE: Rename parameters for SqlRS and SqlAGReplica (#932)
- Changes to SqlRS
  - BREAKING CHANGE: Parameters RSSQLServer and RSSQLInstanceName has been renamed
    to DatabaseServerName and DatabaseInstanceName respectively (issue #923).
- Changes to SqlAGReplica
  - BREAKING CHANGE: Parameters PrimaryReplicaSQLServer and PrimaryReplicaSQLInstanceName
    has been renamed to PrimaryReplicaServerName and PrimaryReplicaInstanceName
    respectively (issue #922).

@vors vors removed the high priority label Dec 6, 2017

@johlju johlju removed the in progress label Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment