SqlAG & SqlAGReplica: Remove parameter SQLServerNetName

[johlju]

Details of the scenario you tried and the problem that is occurring:
The work renaming parameters in issue #308 does not mention the parameter
SQLServerNetName in the resource SqlAG.

https://github.com/PowerShell/SqlServerDsc/blob/9a1080c4da5d513eb4191388206cf37c16c0a0fd/DSCResources/MSFT_SqlAG/MSFT_SqlAG.schema.mof#L23

I suggest we rename it to NetName.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

[johlju]

@randomnote1 @nabrond next one, what do you think?

[johlju]

I'm open for other names. Maybe NetServerName would be more appropriate?

[randomnote1]

NetName is the property off of the server object that is used. This is either the node name or the virtual computer object name of the FCI. ServerNetName would make sense to me.

[johlju]

ServerNetName works for me.

[nabrond]

Should we drop the parameter all together? It looks like it is only used in the Get-TargetResource and Test-TargetResource functions and may be a duplicate of EndpointHostName.

[johlju]

I agree, I think doing the below would result in the same thing, and we could remove the parameter.
@randomnote1 What do think? Either that, or is it a bug that we don't return the value the user set in the parameter EndPointHostName from the Get-TargetResource function?

I'm thinking of the above change, since the Set-TargetResource function already is using NetName property for the parameter EndpointHostname if it is not set.

https://github.com/PowerShell/SqlServerDsc/blob/af10f7147a77c2726521df418b3f05d87b60808d/DSCResources/MSFT_SqlAG/MSFT_SqlAG.psm1#L290-L293

So, changing this row in Get-TargetResource.

https://github.com/PowerShell/SqlServerDsc/blob/af10f7147a77c2726521df418b3f05d87b60808d/DSCResources/MSFT_SqlAG/MSFT_SqlAG.psm1#L79

Into

$alwaysOnAvailabilityGroupResource.EndpointHostName = $serverObject.NetName

and changing this code block in Test-TargetResource function

https://github.com/PowerShell/SqlServerDsc/blob/af10f7147a77c2726521df418b3f05d87b60808d/DSCResources/MSFT_SqlAG/MSFT_SqlAG.psm1#L701-L704

into

 if ( -not $EndpointHostName ) 
 { 
     $EndpointHostName = $getTargetResourceResult.EndpointHostName 
 } 

[johlju]

In the Get-TargetResource function we could also return the value of the EndpointHostName if the parameter is set. If it is not set then we return $serverObject.NetName (the above code).

[randomnote1]

Well, I'm not entirely sure why I chose to create a read-only property for $serverObject.NetName. I'm in favor of using $EndpointHostName and dropping $SQLServerNetName.

[johlju]

@randomnote1 The same logic seem to exist in SqlAgReplica as well. So changing that as well.

Working on this now.

[randomnote1]

That makes sense. Thanks!