New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xCluster: Localization should change to align with HQRM modules #83

Closed
johlju opened this Issue Jul 2, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@johlju
Collaborator

johlju commented Jul 2, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource).

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

johlju added a commit to johlju/xFailOverCluster that referenced this issue Jul 19, 2017

Changes to xCluster
Enabled localization for all strings ([issue #83](PowerShell#83)).

johlju added a commit to johlju/xFailOverCluster that referenced this issue Jul 19, 2017

Changes to xCluster
Enabled localization for all strings ([issue #83](PowerShell#83)).

johlju added a commit to johlju/xFailOverCluster that referenced this issue Jul 19, 2017

Changes to xCluster
Enabled localization for all strings (issue #83).

@johlju johlju referenced this issue Jul 19, 2017

Merged

xCluster: Enabled localization #118

3 of 5 tasks complete

@johlju johlju added in progress and removed help wanted labels Jul 19, 2017

johlju added a commit to johlju/xFailOverCluster that referenced this issue Jul 21, 2017

Changes to xCluster
Enabled localization for all strings (issue #83).

johlju added a commit to johlju/xFailOverCluster that referenced this issue Jul 24, 2017

Changes to xCluster
Enabled localization for all strings (issue #83).

@johlju johlju closed this in #118 Jul 26, 2017

johlju added a commit that referenced this issue Jul 26, 2017

xCluster: Enabled localization (#118)
- Changes to xFailOverCluster
  - Added common test helper functions to help test the throwing of localized error strings.
    - Get-InvalidArgumentRecord
    - Get-InvalidOperationRecord
    - Get-ObjectNotFoundException
    - Get-InvalidResultException.
- Changes to xCluster
  - Enabled localization for all strings (issue #83).
  - Added tests to improve code coverage.

@johlju johlju removed the in progress label Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment