New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xClusterDisk: Localization should change to align with HQRM modules #84

Closed
johlju opened this Issue Jul 2, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@johlju
Collaborator

johlju commented Jul 2, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource).

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

johlju added a commit to johlju/xFailOverCluster that referenced this issue Jul 9, 2017

- Changes to xFailOverCluster
  - Added a common resource helper module with helper functions for localization.
    - Added helper functions; Get-LocalizedData, New-InvalidResultException, New-ObjectNotFoundException, InvalidOperationException and InvalidArgumentException.
  - Fixed lint error MD034 and fixed typos in README.md.
- Changes to xClusterDisk
  - Enabled localization for all strings (issue #84).
- Changes to xClusterPreferredOwner
  - Replace an URL which describes more generic the Role setting for xClusterNetwork.

johlju added a commit to johlju/xFailOverCluster that referenced this issue Jul 14, 2017

- Changes to xFailOverCluster
  - Added a common resource helper module with helper functions for localization.
    - Added helper functions; Get-LocalizedData, New-InvalidResultException, New-ObjectNotFoundException, InvalidOperationException and InvalidArgumentException.
  - Fixed lint error MD034 and fixed typos in README.md.
- Changes to xClusterDisk
  - Enabled localization for all strings (issue #84).
- Changes to xClusterPreferredOwner
  - Replace an URL which describes more generic the Role setting for xClusterNetwork.

@johlju johlju closed this in #111 Jul 18, 2017

johlju added a commit that referenced this issue Jul 18, 2017

xFailOverCluster: Localization support, localized strings in xCluster…
…Disk and some cleanup (#111)

- Changes to xFailOverCluster
  - Added a common resource helper module with helper functions for localization.
    - Added helper functions; Get-LocalizedData, New-InvalidResultException,
      New-ObjectNotFoundException, New-InvalidOperationException and
      New-InvalidArgumentException.
  - Fixed lint error MD034 and fixed typos in README.md.
- Changes to xClusterDisk
  - Enabled localization for all strings ([issue #84](#84)).
- Changes to xClusterNetwork
  - Replaced the URL for the parameter Role in README.md. The new URL is a more
    generic description of the possible settings for the Role parameter. The
    previous URL was still correct but focused on Hyper-V in particular.
  - Fixed typos in parameter descriptions in README.md.

@johlju johlju removed the in progress label Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment