Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xVMHyperV: Wrong localized string is used to throw error messages. #149

Closed
johlju opened this issue May 7, 2018 · 0 comments · Fixed by #163
Closed

xVMHyperV: Wrong localized string is used to throw error messages. #149

johlju opened this issue May 7, 2018 · 0 comments · Fixed by #163
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.

Comments

@johlju
Copy link
Member

johlju commented May 7, 2018

Details of the scenario you tried and the problem that is occurring:
This was reported in PR #148 by @Geogboe.

AutomaticCheckpointsUnsupportedError on line 740 does not resolve to a defined localized data variable and it looks like it should be AutomaticCheckpointsUnsupported instead. Without this change a meaningless error message is produced: ScriptHalted instead of what is should be: AutomaticCheckpoints are not supported on this host."

I think we should change the line 15 to 'AutomaticCheckpointsUnsupportedError' instead (the localized string is used at two locations).

https://github.com/PowerShell/xHyper-V/blob/834dec27c114783ed56b5f430f96fe1d1d6ea4e5/DSCResources/MSFT_xVMHyperV/MSFT_xVMHyperV.psm1#L15

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels May 7, 2018
@SteveL-MSFT SteveL-MSFT added this to In progress in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from In progress in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant