Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Tagged save numbers #176
Not 100% happy with this implementation. Seems overcomplicated.
I considered making it more structure that a Tag is a structure
So yeah, if you have anything simpler let me know. Otherwise
Attention 2 commits, first one is the implementation second one is
This doesn't seem all that complex to me? I mean, it's simple and slightly on the verbose side, but I figured out what was going on here super easily.
We know it works thanks to the great tests, and if something more "elegant" pops into your head later, we can always go back and refactor.
Thanks for the feedback @devonestes ... dunno. It feels like I'm doing something very simple but I need ~30 lines of code to express what I'm doing. Feels too much. Feels like I'm somehow missing a more elegant solution, might just be due to the de-structuring of a string into tis parts though
Often code leaves me happy after I wrote it. This didn't. Felt clumsy.
Anyhow, Ghost isn't clumsy at all.
Jan 19, 2018
Any time you're dealing with parsing actual meaning from a string, that starts to get gnarly pretty quick. I know it sort of feels like it should be easy because it's so easy for us humans, but that's one of the things computers unfortunately still are terrible at.
Some of the worst code I've ever written is all around trying to do some sort of natural language processing, or normalizing user input. Language is nasty stuff.