Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Calculate memory stats #180
Ok, at this point a lot is going on here. Right now there are minimal tests on the new behavior, which I've used to refactor the initial messy implementation into something not too bad. At this point, things I still have left to do are:
The major things I've done in this PR so far are:
So, right now just about everything is working (except the extended statistics for memory), and if y'all wanted to you could play with it. It'll take some time to fully test and document everything, which is why I wanted to put this up now to get feedback while I'm starting on that stuff.
Contributed a short fix for relative memory display
FYI I just ran my TCO blogpost code (tail-recursive vs. body-recursive) with memory measurements enabled, results look good:
Looks great, thank you so much for all the work your poured into this!
Sorry it took me so long to get to this, I really wanted to have a relaxed moment (or rather multiple) to give this its due diligence. :)
Test wise I think it'd be nice to have a high level test in the benchee test or/and the runenr test but these might already exist from the previous approach in which case I'll shut up :)
Looks great, I have a couple of more minor points somewhere but we can do those another time. This has been open long enough and should finally land :)
There's one super tiny thing but I'll just fix it right away.
yum yum I like to measure the length of sticks