New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended stats for memory usage #200

Merged
merged 1 commit into from Mar 24, 2018

Conversation

Projects
None yet
2 participants
@devonestes
Collaborator

devonestes commented Mar 21, 2018

Now if folks want to see the extended info for memory usage, they can!
It still won't show if there is no variation in the measurements.

After this, we can probably release 0.13, right? Or is there anything
else we'll need for that?

Closes #191

Add extended stats for memory usage
Now if folks want to see the extended info for memory usage, they can!
It still won't show if there is no variation in the measurements.
@@ -41,6 +43,7 @@ defmodule Benchee.Utility.FileCreationIntegrationTest do
assert output =~ @file_name_2
after
File.rm_rf! @directory
File.rm_rf! "testing"

This comment has been minimized.

@devonestes

devonestes Mar 21, 2018

Collaborator

Because we were doing rm_rf! on testing/files, we were always leaving the testing folder around, which has bothered me for a bit. Now that's gone, too!

@PragTob

This comment has been minimized.

Owner

PragTob commented Mar 22, 2018

Yes this is the last open issue in 0.13. I'm a bit under the weather so review might take me a little while, sorry :(

@PragTob

This comment has been minimized.

Owner

PragTob commented Mar 22, 2018

secret camera footage of my recovering:

img_20180120_131128

@PragTob

beautiful!

img_20180321_072153

@PragTob PragTob merged commit f55137b into master Mar 24, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 94.575%
Details

@PragTob PragTob deleted the issue-191 branch Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment