New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputObjects created in order of modules arg #72

Closed
ianmseddy opened this Issue Aug 29, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@ianmseddy

ianmseddy commented Aug 29, 2018

inputObjects are created following the order of the modules in the simList, instead of the loadOrder.

achubaty added a commit that referenced this issue Sep 7, 2018

achubaty added a commit that referenced this issue Sep 7, 2018

run .inputObjects after module load order computed (#72)
@ianmseddy please test

@eliotmcintire please review changes to unit tests (especially `test-timeunits.R`)
@achubaty

This comment has been minimized.

Contributor

achubaty commented Sep 8, 2018

UGH! @ianmseddy @eliotmcintire looks like I broke things in a subtle way trying to fix this. don't use it yet!

@achubaty

This comment has been minimized.

Contributor

achubaty commented Sep 10, 2018

@ianmseddy please test

@ianmseddy

This comment has been minimized.

ianmseddy commented Sep 10, 2018

Great, I'll test tomorrow morning.

achubaty added a commit that referenced this issue Sep 11, 2018

@achubaty achubaty closed this in c049fe4 Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment