Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cater for change in data.table v1.11.0 #64

Merged
merged 2 commits into from May 16, 2018

Conversation

@mattdowle
Copy link
Contributor

@mattdowle mattdowle commented Apr 28, 2018

Dear SpaDES.core team,

Thanks for using data.table! Sorry for the inconvenience on this one.

Reverse dependency testing revealed SpaDES.core will break with the data.table v1.11.0 update to CRAN.
Bug fix 8 in v1.11.0 NEWS is :

  1. Printing a null data.table with print no longer visibly outputs NULL, #1852. Thanks @aaronmcdaid for spotting and @MichaelChirico for the PR.

This PR should make SpaDES.core pass R CMD check with data.table both before and after v1.11.0

The failure is :

── 1. Failure: simList object initializes correctly (@test-simList.R#17)  ──────────────────────────
length(out) not equal to 75.
1/1 mismatches
[1] 73 - 75 == -2
══ testthat results  ═══════════════════════════════════════════════════════════
OK: 349 SKIPPED: 33 FAILED: 1
1. Failure: simList object initializes correctly (@test-simList.R#17) 
Reverse dependency testing revealed `SpaDES.core` will break with the data.table v1.11.0 update to CRAN.
Bug fix 8 in v1.11.0 NEWS is :
> 8. Printing a null `data.table` with `print` no longer visibly outputs `NULL`, [#1852](Rdatatable/data.table#1852). Thanks @aaronmcdaid for spotting and @MichaelChirico for the PR.

This PR should make SpaDES.core pass R CMD check with data.table both before and after v1.11.0

The failure is :
```
── 1. Failure: simList object initializes correctly (@test-simList.R#17)  ──────────────────────────
length(out) not equal to 75.
1/1 mismatches
[1] 73 - 75 == -2
══ testthat results  ═══════════════════════════════════════════════════════════
OK: 349 SKIPPED: 33 FAILED: 1
1. Failure: simList object initializes correctly (@test-simList.R#17) 
```
@@ -14,7 +14,8 @@ test_that("simList object initializes correctly", {
w <- getOption("width")
options(width = 100L)
out <- utils::capture.output(show(mySim))
expect_equal(length(out), 75)
nline <- if (out[60]=="NULL") 75 else 73 # data.table v1.11.0 no longer prints "NULL" data.table (bug fix 8 in NEWS)

This comment has been minimized.

@MichaelChirico

MichaelChirico Apr 29, 2018

maybe tag which version of NEWS for future reference

This comment has been minimized.

@mattdowle

mattdowle May 11, 2018
Author Contributor

The comment on that line includes v1.11.0 ?

@achubaty
Copy link
Contributor

@achubaty achubaty commented May 2, 2018

Thank you for the head's up and for the PR. Can you please change the target branch to "development"?

@mattdowle mattdowle changed the base branch from master to development May 11, 2018
@achubaty achubaty merged commit 2e183df into PredictiveEcology:development May 16, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@achubaty
Copy link
Contributor

@achubaty achubaty commented May 16, 2018

thank you!

@mattdowle mattdowle deleted the mattdowle:patch-1 branch May 16, 2018
@mattdowle mattdowle mentioned this pull request Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants