Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaussMap alternative models #20

Merged
merged 4 commits into from Feb 23, 2018
Merged

Conversation

@ianmseddy
Copy link
Contributor

@ianmseddy ianmseddy commented Feb 22, 2018

Added potential alternatives to exponential model used in gaussMap function

Copy link
Contributor

@eliotmcintire eliotmcintire left a comment

Thanks. The next enhancement to this could make it more generic, allowing for any of the RM*** functions to be used. @SteveCumming this can now use a gaussian semivariance model.

@eliotmcintire eliotmcintire merged commit 3258ea7 into PredictiveEcology:master Feb 23, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@achubaty
Copy link
Contributor

@achubaty achubaty commented Feb 23, 2018

@ianmseddy can you please resubmit this one to the development branch?

@achubaty
Copy link
Contributor

@achubaty achubaty commented Feb 23, 2018

hopefully it lets you do this even though the changes were merged (then reverted). you may need to make an additional change (update date in DESCRIPTION).

@ianmseddy
Copy link
Contributor Author

@ianmseddy ianmseddy commented Feb 23, 2018

It doesn't give me the option when I try to edit it. I think because it was already merged, whereas the example it is still open.

@achubaty
Copy link
Contributor

@achubaty achubaty commented Feb 23, 2018

Ok then, I guess you'll have to make a new PR. I was hoping GitHub would make this easier...

achubaty added a commit that referenced this pull request Feb 23, 2018
take PR20 which was accidentally merged into master instead of develpment branch:

Was missing the NAMESPACE file to add RMgauss and RMstable

Added alternatives to Gaussian exponential model for gaussMap function

Merge remote-tracking branch 'refs/remotes/origin/master'
@achubaty
Copy link
Contributor

@achubaty achubaty commented Feb 23, 2018

since it was just 4 commits, I cherrypicked them, added some changes of my own and squashed into a single commit on development

achubaty added a commit that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants