Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
modules & simulations should use `timestep` from metadata #151
scheduling of events etc. should convert the timestep for each module, such that modules with different timesteps are "rescaled" automatically to work correctly together.
This is done. It will likely need tweaking. But, essentially, timestep has greatest meaning if it is a character string, with a "unit", like "year", "month", "day", "week", "hour", "second" etc. These all work now. So, just write a single character string, and all the modules will just "work" together, as desired. See commit: 54353bf .
This has not been merged into Development, but development has been merged into this and there were no errors.
It should be backwards compatible because NA defaults to "year" if no module is used that has a timestep, and defaults to the longest units if other modules have defined timestep.
I contemplated changing the list entry label from "timestep" to "timestepUnit", which is likely more accurate, but that would require many changes to existing modules. Which needs a discussion.