Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split off non-core functions into another package #198

Closed
achubaty opened this issue Jun 19, 2015 · 14 comments
Closed

split off non-core functions into another package #198

achubaty opened this issue Jun 19, 2015 · 14 comments
Assignees
Milestone

Comments

@achubaty
Copy link
Contributor

@achubaty achubaty commented Jun 19, 2015

Many of these aren't well tested and documented, and aren't required for SpaDES itself (e.g., crw, spread, etc.) so it may be best to put them in a new package e.g., SpaDES_toolbox.

Several of our outstanding issues are enhancements etc. related to these 'extras' at could be moved to the other repo/package:

NOTE: we will need to reorganize the vignettes and sample modules as they rely on many of these 'extras'.

@achubaty achubaty self-assigned this Jun 19, 2015
@achubaty achubaty added this to the v1.0.0 milestone Jun 19, 2015
@eliotmcintire eliotmcintire removed this from the v1.0.0 milestone Jun 29, 2015
@eliotmcintire
Copy link
Contributor

@eliotmcintire eliotmcintire commented Jul 30, 2015

This is in next release, so lower priority.

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Nov 24, 2016

use https://github.com/google/github-issue-mover to transfer appropriate issues from this repo into the new package repos

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jan 28, 2017

It may be time to consider splitting the package:

Status: 1 NOTE
checking installed package size ... NOTE
  installed size is  5.4Mb
  sub-directories of 1Mb or more:
    R     1.6Mb
    doc   2.1Mb

Proposed packages:

  • SpaDES: a metapackage that imports all the others and loads them per tidyverse

    • Imports (with library call in zzz.R): quickPlot, reproducible, SpaDES.extra, SpaDES.shiny, SpaDES.tools
  • SpaDES.core: the core DES

    • Depends: reproducible
    • Imports: quickPlot
    • Suggests: SpaDES.extra, SpaDES.tools
  • SpaDES.cache reproducible: provides simulation caching mechanisms.

    • Extends SpaDES.core
  • SpaDES.extra (NOT YET BUILT): additional general-purpose modules, e.g. translator modules like #329, 'crop-load-reproject' module, and output analysis modules

    • Extends: SpaDES.core
  • SpaDES.plot quickPlot: modular plotting

    • Extends: SpaDES.core
  • SpaDES.shiny: move all shiny/SpaDESUI related stuff here

    • Extends: SpaDES.core
  • SpaDES.tools: additonal functions for building spatial simulation models (crw, spread, etc.)

    • Extends: SpaDES.core
  • SpaDES.addins: Rstudio addins for SpaDES and SpaDES module development

    • Imports: SpaDES / SpaDES.core
@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jan 28, 2017

added SpaDES.shiny above

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Mar 28, 2017

@eliotmcintire we need to coordinate this split. When can you pause development of caching/spreading so that we can split the package?

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Mar 31, 2017

we should aim to have our next CRAN update ready for the release of R 3.4.0 on April 21, 2017

@achubaty achubaty added this to the v1.4.0 milestone Apr 4, 2017
@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jun 20, 2017

started...

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jun 28, 2017

moved Rstudio addins out of development branch and into their own package (https://github.com/PredictiveEcology/SpaDES.addins; b5c49c8)

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jun 28, 2017

moved shine() out of SpaDES and into SpaDES.shiny (f0848ed)

achubaty referenced this issue Jun 28, 2017
@eliotmcintire, I'm setting the spinoff packages to expect `SpaDES > 1.3.1.9200`
@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jun 29, 2017

😢 just hit an issue with the proposed package names: C++ doesn't allow dots in the names, so Rcpp errors (see here; and here).

@eliotmcintire are you OK with using underscores (e.g., SpaDES_tools)?

Otherwise we may be able to wait for the fixed Rcpp to appear on CRAN. Looks like that linked issue was closed today.

@eliotmcintire
Copy link
Contributor

@eliotmcintire eliotmcintire commented Jun 29, 2017

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jun 29, 2017

Latest Rcpp works fine: install_github("RcppCore/Rcpp")

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jun 30, 2017

moved various pieces into SpaDES.tools (PredictiveEcology/SpaDES.tools@46d3dc2)

@achubaty achubaty added the in progress label Jul 6, 2017
achubaty added a commit to PredictiveEcology/SpaDES.addins that referenced this issue Jul 6, 2017
achubaty added a commit to PredictiveEcology/SpaDES.core that referenced this issue Jul 6, 2017
achubaty added a commit that referenced this issue Jul 10, 2017
- core DES components now in `PredictiveEcology/SpaDES.core`
- extra simulation tools now in `PredictiveEcology/SpaDES.tools`
@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Sep 5, 2017

completed.

@achubaty achubaty closed this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants