Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not assume any packages other than base are imported/available #201

Closed
achubaty opened this issue Jun 30, 2015 · 4 comments
Closed

do not assume any packages other than base are imported/available #201

achubaty opened this issue Jun 30, 2015 · 4 comments
Assignees

Comments

@achubaty
Copy link
Contributor

@achubaty achubaty commented Jun 30, 2015

New change on R-devel:

‘R CMD check --as-cran’ now checks code usage (via ‘codetools’) with only the base package attached, so that functions from default packages other than base which are used in the package code but not imported are reported as undefined globals.

This means we need to explicitly use importFrom for everything other than base functions.

@achubaty achubaty added this to the v1.0.0 milestone Jun 30, 2015
@achubaty achubaty self-assigned this Jun 30, 2015
@eliotmcintire
Copy link
Contributor

@eliotmcintire eliotmcintire commented Jul 30, 2015

I think this is done. All checks passing now, with no depends used. Now only igraph, graphics, methods are loaded with @import ... all other functions are individually imported with @importFrom

@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Jul 30, 2015

have you checked this against R-devel? I want to hold off closing this until we know it passes there.

@eliotmcintire
Copy link
Contributor

@eliotmcintire eliotmcintire commented Jul 30, 2015

No. I haven't.

@eliotmcintire eliotmcintire reopened this Jul 30, 2015
@eliotmcintire
Copy link
Contributor

@eliotmcintire eliotmcintire commented Jul 31, 2015

Run on win-builder July 30, 2015. Passes.
c590cfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants