Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove attach in spades call #212

Closed
eliotmcintire opened this issue Aug 7, 2015 · 3 comments
Closed

remove attach in spades call #212

eliotmcintire opened this issue Aug 7, 2015 · 3 comments

Comments

@eliotmcintire
Copy link
Contributor

@eliotmcintire eliotmcintire commented Aug 7, 2015

This is in response to CRAN not wanting the attach call, even though we followed their best practices as described within the attach function.

@eliotmcintire
Copy link
Contributor Author

@eliotmcintire eliotmcintire commented Aug 7, 2015

Hey... A thought... what about putting them in the SpaDES namespace? The functions are loaded within the simInit call, so we can put them in the SpaDES namespace... @achubaty @SteveCumming thoughts? Is this possible?

@eliotmcintire
Copy link
Contributor Author

@eliotmcintire eliotmcintire commented Aug 7, 2015

Done in branch -- remove_attach
5f46e39
a36afcc
cf9f56d

Passes all R CMD tests on Windows.

@achubaty
Copy link
Contributor

@achubaty achubaty commented Aug 7, 2015

what about putting them in the SpaDES namespace? The functions are loaded within the simInit call, so we can put them in the SpaDES namespace...

I think we should keep the package functions separate from user functions.

@achubaty achubaty closed this Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants