Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty module list with no parent modules and no object dependencies #215

Closed
achubaty opened this issue Aug 11, 2015 · 2 comments
Closed

empty module list with no parent modules and no object dependencies #215

achubaty opened this issue Aug 11, 2015 · 2 comments

Comments

@achubaty
Copy link
Contributor

@achubaty achubaty commented Aug 11, 2015

module list (and load order) incorrectly built during simInit when the following conditions are both met:

  1. there are no parent modules
  2. the modules to be loaded do not have any shared data objects

The issue is with the way the modules are parsed (see .parseModule):

  1. When no parent modules are loaded, append_attr(modules, all_children)[-parent_ids] returns an empty list, which then gets assigned to modules(sim).
  2. Module load order relies on the module list in modules(sim) and the modules in depsGraph(). Any modules not in the edgeList get missed when the modules list is empty.
@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Aug 11, 2015

fix being tested and will be pushed shortly.

the workaround for the CRAN version is to manually specify loadOrder in the simInit call.

@achubaty achubaty closed this Aug 11, 2015
@achubaty achubaty reopened this Aug 12, 2015
@achubaty
Copy link
Contributor Author

@achubaty achubaty commented Aug 12, 2015

I'll keep this open for now -- the issue will automatically close once merged into master.

I've created a pre-release version 1.0.1.9001 with this fix applied, which can be downloaded and installed manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant