Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assigning inputs(sim) during simInit fails due to file incorrectly being typed as factor #225

Closed
YongLuo007 opened this issue Sep 4, 2015 · 1 comment

Comments

@YongLuo007
Copy link
Contributor

@YongLuo007 YongLuo007 commented Sep 4, 2015

From lines 380-385 of simulation.R

inputs(sim) <- bind_rows(list(
        inputs(sim),
        data.frame(objectName=names(objects), loaded=TRUE,
                   loadTime=as.numeric(time(sim, "seconds")),
                   stringsAsFactors=FALSE)
      ))

when providing a named list of objects to simInit, the bind_rows call produces a dataframe with NA's in the file column being set as factors. coercing the column to character solves the issue.

@achubaty
Copy link
Contributor

@achubaty achubaty commented Sep 5, 2015

related: inputs<- seems to be setting an absolute path for objects that have NA in the file column

achubaty added a commit that referenced this issue Sep 9, 2015
for fix #225
@achubaty achubaty closed this in a875f40 Sep 9, 2015
eliotmcintire pushed a commit that referenced this issue Sep 11, 2015
eliotmcintire pushed a commit that referenced this issue Sep 11, 2015
Eliot McIntire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants