New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve/clarify implementation & use of parent modules #300

Closed
achubaty opened this Issue Sep 7, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@achubaty
Contributor

achubaty commented Sep 7, 2016

per discussion with @eliotmcintire :

  • add new arguments type = c("child", "parent") and children = c() to newModule(): default is type = "child"; if parent module specified, then a character vector (or list) of child module names is required, in order to fill in the childModules field in the metadata.
  • implement automatic parsing of specified child modules to fill in the remaining metadata fields of the new parent module (this is for human readers only; metadata of parent modules aren't parsed the way they are for children). [WON'T IMPLEMENT NOW]

@achubaty achubaty added this to the v1.3.0 milestone Sep 7, 2016

@achubaty achubaty self-assigned this Sep 7, 2016

achubaty added a commit that referenced this issue Sep 11, 2016

add new args to 'newModule' (#300)
* `newModule` (and related) gains new arguments `type = c("child", "parent")` and `children = c()`: default is `type = "child"`; if parent module specified, then a character vector (or list) of child module names is required, in order to fill in the `childModules` field in the metadata.

achubaty added a commit that referenced this issue Sep 13, 2016

@achubaty

This comment has been minimized.

Contributor

achubaty commented Sep 13, 2016

won't implement the automatic parsing of child modules at this point. perhaps in the future... closing this issue to prep v1.3.0 CRAN release.

@achubaty achubaty closed this Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment