New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unitTests argument was added into newModule function #242

Merged
merged 3 commits into from Dec 24, 2015

Conversation

Projects
None yet
3 participants
@YongLuo007
Copy link
Contributor

YongLuo007 commented Dec 21, 2015

a unitTests argument was added in newModule function. please verify using following codes:
source("/GitHub/SpaDES/R/misc-methods.R")
source("
/GitHub/SpaDES/R/module-template.R")
newModule("testModule",open=FALSE)

@achubaty

This comment has been minimized.

Copy link
Contributor

achubaty commented Dec 23, 2015

@eliotmcintire automatic checks on this PR fail due to undocumented code:

* checking for missing documentation entries ... WARNING
Undocumented S4 methods:
  generic 'newModule' and siglist 'character,character,logical,logical'
  generic 'newModule' and siglist 'character,character,logical,missing'
  generic 'newModule' and siglist 'character,character,missing,logical'
  generic 'newModule' and siglist 'character,character,missing,missing'
  generic 'newModule' and siglist 'character,missing,logical,logical'
  generic 'newModule' and siglist 'character,missing,logical,missing'
  generic 'newModule' and siglist 'character,missing,missing,logical'
  generic 'newModule' and siglist 'character,missing,missing,missing'
All user-level objects in a package (including S4 classes and methods)
should have documentation entries.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.
* checking for code/documentation mismatches ... WARNING
Codoc mismatches from documentation object 'newModule':
newModule
  Code: function(name, path, open, unitTests)
  Docs: function(name, path, open)
  Argument names in code not in docs:
    unitTests

YongLuo007 added some commits Dec 23, 2015

@eliotmcintire eliotmcintire merged commit 4a76893 into PredictiveEcology:development Dec 24, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on development at 74.985%
Details
@eliotmcintire

This comment has been minimized.

Copy link
Contributor

eliotmcintire commented Dec 24, 2015

Done, with my additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment