New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #245

Merged
merged 12 commits into from Jan 22, 2016

Conversation

Projects
None yet
2 participants
@YongLuo007
Copy link
Contributor

YongLuo007 commented Dec 31, 2015

please check the pull request and let me know if there is any problem. thanks.

modules = list(paste0(name)),
objects = list(),
paths = list(modulePath = path,
outputPath = "~/output"))

This comment has been minimized.

@achubaty

achubaty Jan 13, 2016

Contributor

don't use hard-coded paths. create temp dir to use for coverage testing.

sim <- scheduleEvent(sim, params(sim)$", name, "$.plotInitialTime, \"", name, "\", \"plot\")
sim <- scheduleEvent(sim, params(sim)$", name, "$.saveInitialTime, \"", name, "\", \"save\")
} else if (eventType == \"plot\") {
# Everything in this file gets sourced during simInit, and all functions and objects

This comment has been minimized.

@achubaty

achubaty Jan 13, 2016

Contributor

all of the added indenting in this file may mess up the indenting of the file produced by cat()

#'
#' @param path Character string. Subdirectory in which to place the new module code file.
#' The default is the current working directory.
#'

This comment has been minimized.

@achubaty

achubaty Jan 13, 2016

Contributor

i'm not sure I understand why this needs to be specified. coverage testing can be done entirely in a temp dir, can't it?

#' tmpdir <- tempdir(); on.exit(unlink(tmpdir, recursive = TRUE))
#' modulePath <- file.path(tmpdir, "Modules")
#' moduleName <- "forestAge"
#' downloadModule(name = moduleName, path = modulePath)

This comment has been minimized.

@achubaty

achubaty Jan 13, 2016

Contributor

as discussed, module coverage testing is intended to be use by the module developer on local files, so we can assume that the local files exist -- we don't need to download the module from the repo.

# startTime = times$start+1, .plotInitialTime = times$start, .plotInterval = 1),
#caribouMovementLcc = list(
# N = 1e3, moveInterval = 1, startTime = times$start+1, torus = TRUE,
# glmInitialTime = NA_real_, .plotInitialTime = times$start, .plotInterval = 1)

This comment has been minimized.

@achubaty

achubaty Jan 13, 2016

Contributor

why are these commented lines being added to the template? they are specific to the LCC modules.

achubaty added a commit that referenced this pull request Jan 22, 2016

Merge pull request #245 from YongLuo007/development
merging and I will make the changes noted in the line comments

@achubaty achubaty merged commit 07a51d5 into PredictiveEcology:development Jan 22, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.7%) to 74.316%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

achubaty added a commit that referenced this pull request Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment