New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #257

Merged
merged 35 commits into from Feb 9, 2016

Conversation

Projects
None yet
3 participants
@YongLuo007
Copy link
Contributor

YongLuo007 commented Feb 6, 2016

No description provided.

YongLuo007 added some commits Jan 28, 2016

revised moduleCoverage
1.  avoided hard coded path for fnDir by using tempdir(), and located
outputDir inside of fnDir.

2. added a argument of byFunctionName to allow moduleCoverage scan the
test files by function name in the module

3. added two tables in returns: testedFunctions and untestedFunctions
moduleCoverage improvements
1. added a argument byFunctionName
2. removed the hard coded path
3. added two data tables as return
Merge remote-tracking branch 'refs/remotes/PredictiveEcology/developm…
…ent' into development1

# Conflicts:
#	tests/testthat/test-downloadModule.R
@achubaty

This comment has been minimized.

Copy link

achubaty commented on f57cdc0 Feb 3, 2016

please don't turn off other unit tests

YongLuo007 added some commits Feb 3, 2016

Merge remote-tracking branch 'refs/remotes/PredictiveEcology/developm…
…ent' into development

# Conflicts:
#	R/misc-methods.R
#	R/module-template.R
#	R/moduleCoverage.R
#	R/plotting-colours.R
#	tests/testthat/test-Plot.R
#	tests/testthat/test-adj.R
#	tests/testthat/test-checkPath.R
#	tests/testthat/test-checkpoint.R
#	tests/testthat/test-downloadModule.R
#	tests/testthat/test-mapReduce.R
#	tests/testthat/test-module-template.R

YongLuo007 added some commits Feb 6, 2016

added instruction for user to specify test file's name
this is one solution for speed up moduleCoverage function as Alex and me
discussed

eliotmcintire added a commit that referenced this pull request Feb 9, 2016

@eliotmcintire eliotmcintire merged commit 3461d78 into PredictiveEcology:development Feb 9, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

achubaty added a commit that referenced this pull request Feb 9, 2016

cleanup/updates following PR257
with #257

* spellcheck / grammar
* improve formatting
* update NEWS
* redoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment